From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/2] dt: platform driver: Fill the resources before probe and defer if needed
Date: Fri, 18 Apr 2014 13:52:14 -0700 [thread overview]
Message-ID: <20140418205213.GA21823@atomide.com> (raw)
In-Reply-To: <CAL_Jsq+aU+rs28gV=Gesb_-Dy6Ht7zuKrRA6_hmqp94Uun23Yg@mail.gmail.com>
* Rob Herring <robherring2@gmail.com> [140411 10:33]:
> On Fri, Mar 21, 2014 at 9:46 AM, Jean-Jacques Hiblot
> <jjhiblot@traphandler.com> wrote:
> > The goal of this patch is to allow drivers to be probed even if at the time of
> > the DT parsing some of their IRQ ressources are not available yet.
> >
> > In the current situation, the IRQ resources of a platform device are filled from
> > the DT at the time the device is created (of_device_alloc()). The drawback of
> > this is that a device sitting close to the top of the DT (ahb for example) but
> > depending on ressources that are initialized later (IRQ domain dynamically
> > created for example) will fail to probe because the ressources don't exist
> > at this time.
>
> s/ressources/resources/
While I've tested these two patches and they fix the issue for me. I have
some serious doubts again about this whole ------ up string parsing
pile of ---- called device tree.
Do we really need to sprinkle more of_* hacks to the irq subsystem?
There's nothing wrong with with the irq subsystem. Platform bus is just
calling the irq subsystem at the wrong time with uninitialized data.
It seems that we're again papering over the fact that there's nothing
coordinating the setting up of various resources with device tree.
That seems to be the repeating never ending pattern as we've already
seen with GPIOs, pinctrl, and IRQchips. We end up adding all kinds of
cross subsystem calls that were never needed earlier.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
To: Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Jean-Jacques Hiblot
<jjhiblot-dLKeG7h1OhBDOHtkgc7UlQ@public.gmane.org>,
Grant Likely
<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Gregory Clement
<gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH v3 2/2] dt: platform driver: Fill the resources before probe and defer if needed
Date: Fri, 18 Apr 2014 13:52:14 -0700 [thread overview]
Message-ID: <20140418205213.GA21823@atomide.com> (raw)
In-Reply-To: <CAL_Jsq+aU+rs28gV=Gesb_-Dy6Ht7zuKrRA6_hmqp94Uun23Yg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
* Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> [140411 10:33]:
> On Fri, Mar 21, 2014 at 9:46 AM, Jean-Jacques Hiblot
> <jjhiblot-dLKeG7h1OhBDOHtkgc7UlQ@public.gmane.org> wrote:
> > The goal of this patch is to allow drivers to be probed even if at the time of
> > the DT parsing some of their IRQ ressources are not available yet.
> >
> > In the current situation, the IRQ resources of a platform device are filled from
> > the DT at the time the device is created (of_device_alloc()). The drawback of
> > this is that a device sitting close to the top of the DT (ahb for example) but
> > depending on ressources that are initialized later (IRQ domain dynamically
> > created for example) will fail to probe because the ressources don't exist
> > at this time.
>
> s/ressources/resources/
While I've tested these two patches and they fix the issue for me. I have
some serious doubts again about this whole ------ up string parsing
pile of ---- called device tree.
Do we really need to sprinkle more of_* hacks to the irq subsystem?
There's nothing wrong with with the irq subsystem. Platform bus is just
calling the irq subsystem at the wrong time with uninitialized data.
It seems that we're again papering over the fact that there's nothing
coordinating the setting up of various resources with device tree.
That seems to be the repeating never ending pattern as we've already
seen with GPIOs, pinctrl, and IRQchips. We end up adding all kinds of
cross subsystem calls that were never needed earlier.
Regards,
Tony
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Rob Herring <robherring2@gmail.com>
Cc: Jean-Jacques Hiblot <jjhiblot@traphandler.com>,
Grant Likely <grant.likely@secretlab.ca>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Gregory Clement <gregory.clement@free-electrons.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 2/2] dt: platform driver: Fill the resources before probe and defer if needed
Date: Fri, 18 Apr 2014 13:52:14 -0700 [thread overview]
Message-ID: <20140418205213.GA21823@atomide.com> (raw)
In-Reply-To: <CAL_Jsq+aU+rs28gV=Gesb_-Dy6Ht7zuKrRA6_hmqp94Uun23Yg@mail.gmail.com>
* Rob Herring <robherring2@gmail.com> [140411 10:33]:
> On Fri, Mar 21, 2014 at 9:46 AM, Jean-Jacques Hiblot
> <jjhiblot@traphandler.com> wrote:
> > The goal of this patch is to allow drivers to be probed even if at the time of
> > the DT parsing some of their IRQ ressources are not available yet.
> >
> > In the current situation, the IRQ resources of a platform device are filled from
> > the DT at the time the device is created (of_device_alloc()). The drawback of
> > this is that a device sitting close to the top of the DT (ahb for example) but
> > depending on ressources that are initialized later (IRQ domain dynamically
> > created for example) will fail to probe because the ressources don't exist
> > at this time.
>
> s/ressources/resources/
While I've tested these two patches and they fix the issue for me. I have
some serious doubts again about this whole ------ up string parsing
pile of ---- called device tree.
Do we really need to sprinkle more of_* hacks to the irq subsystem?
There's nothing wrong with with the irq subsystem. Platform bus is just
calling the irq subsystem at the wrong time with uninitialized data.
It seems that we're again papering over the fact that there's nothing
coordinating the setting up of various resources with device tree.
That seems to be the repeating never ending pattern as we've already
seen with GPIOs, pinctrl, and IRQchips. We end up adding all kinds of
cross subsystem calls that were never needed earlier.
Regards,
Tony
next prev parent reply other threads:[~2014-04-18 20:52 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 9:57 [PATCH] dt: platform driver: Fill the resources before probe and defer if needed Jean-Jacques Hiblot
2014-02-13 9:57 ` Jean-Jacques Hiblot
2014-02-13 9:57 ` Jean-Jacques Hiblot
2014-02-13 10:06 ` Jean-Jacques Hiblot
2014-02-13 10:06 ` Jean-Jacques Hiblot
2014-02-18 20:22 ` Greg KH
2014-02-18 20:22 ` Greg KH
2014-02-18 22:34 ` Grant Likely
2014-02-18 22:34 ` Grant Likely
2014-02-20 15:30 ` Grant Likely
2014-02-20 15:30 ` Grant Likely
2014-02-20 15:30 ` Grant Likely
[not found] ` < 1392988720-20976-1-git-send-email-jjhiblot@traphandler.com>
[not found] ` <20140308073758 .DA63FC408EC@trevor.secretlab.ca>
[not found] ` < CACh+v5P=tcc-h_9r7Btwyu+jWjwH2ocmW4VCgDYqY7VMWsHuOA@mail.gmail.com>
[not found] ` < 20140317142443.A2447C40A85@trevor.secretlab.ca>
[not found] ` < 902E09E6452B0E43903E4F2D568737AB0B9D2959@DFRE01.ent.ti.com>
[not found] ` < CACh+v5MPTx6nwVj1s3krntJqQ6DMTQ2hQ93Hc+rRNAuFa9+qPw@mail.gmail.com>
2014-02-21 13:18 ` [PATCH v2] " Jean-Jacques Hiblot
2014-02-21 13:18 ` Jean-Jacques Hiblot
2014-02-21 15:37 ` Strashko, Grygorii
2014-02-21 15:37 ` Strashko, Grygorii
2014-02-21 15:37 ` Strashko, Grygorii
2014-02-21 16:22 ` Jean-Jacques Hiblot
2014-02-21 16:22 ` Jean-Jacques Hiblot
2014-02-27 16:43 ` Jean-Jacques Hiblot
2014-02-27 16:43 ` Jean-Jacques Hiblot
2014-02-27 16:43 ` Jean-Jacques Hiblot
2014-03-08 7:32 ` Grant Likely
2014-03-08 7:32 ` Grant Likely
2014-03-08 7:32 ` Grant Likely
2014-02-27 15:01 ` Ludovic Desroches
2014-02-27 15:01 ` Ludovic Desroches
2014-02-27 15:01 ` Ludovic Desroches
2014-03-08 7:37 ` Grant Likely
2014-03-08 7:37 ` Grant Likely
2014-03-08 7:37 ` Grant Likely
2014-03-08 11:59 ` Russell King - ARM Linux
2014-03-08 11:59 ` Russell King - ARM Linux
2014-03-08 11:59 ` Russell King - ARM Linux
2014-03-17 11:07 ` Jean-Jacques Hiblot
2014-03-17 11:07 ` Jean-Jacques Hiblot
2014-03-17 11:07 ` Jean-Jacques Hiblot
2014-03-17 14:24 ` Grant Likely
2014-03-17 14:24 ` Grant Likely
2014-03-17 14:24 ` Grant Likely
2014-03-17 15:20 ` Jean-Jacques Hiblot
2014-03-17 15:20 ` Jean-Jacques Hiblot
2014-03-20 16:11 ` Grant Likely
2014-03-20 16:11 ` Grant Likely
2014-03-20 16:11 ` Grant Likely
2014-03-21 14:46 ` [PATCH v3 0/2] " Jean-Jacques Hiblot
2014-03-21 14:46 ` Jean-Jacques Hiblot
2014-03-21 14:46 ` Jean-Jacques Hiblot
2014-03-21 14:46 ` [PATCH v3 1/2] of: irq: Added of_find_irq_domain() to get the domain of an irq Jean-Jacques Hiblot
2014-03-21 14:46 ` Jean-Jacques Hiblot
2014-03-21 14:46 ` Jean-Jacques Hiblot
2014-03-21 14:46 ` [PATCH v3 2/2] dt: platform driver: Fill the resources before probe and defer if needed Jean-Jacques Hiblot
2014-03-21 14:46 ` Jean-Jacques Hiblot
2014-04-11 17:28 ` Rob Herring
2014-04-11 17:28 ` Rob Herring
2014-04-18 20:52 ` Tony Lindgren [this message]
2014-04-18 20:52 ` Tony Lindgren
2014-04-18 20:52 ` Tony Lindgren
2014-04-18 21:39 ` Rob Herring
2014-04-18 21:39 ` Rob Herring
2014-04-18 21:39 ` Rob Herring
2014-04-18 21:58 ` Tony Lindgren
2014-04-18 21:58 ` Tony Lindgren
2014-04-18 21:58 ` Tony Lindgren
2014-04-18 23:03 ` Russell King - ARM Linux
2014-04-18 23:03 ` Russell King - ARM Linux
2014-04-18 23:03 ` Russell King - ARM Linux
2014-04-18 23:24 ` Tony Lindgren
2014-04-18 23:24 ` Tony Lindgren
2014-04-18 23:24 ` Tony Lindgren
2014-04-21 13:47 ` Rob Herring
2014-04-21 13:47 ` Rob Herring
2014-04-21 15:54 ` Tony Lindgren
2014-04-21 15:54 ` Tony Lindgren
2014-04-21 15:54 ` Tony Lindgren
2014-04-21 19:01 ` Rob Herring
2014-04-21 19:01 ` Rob Herring
2014-04-21 19:01 ` Rob Herring
2014-04-21 20:25 ` Tony Lindgren
2014-04-21 20:25 ` Tony Lindgren
2014-04-21 20:25 ` Tony Lindgren
2014-04-22 3:05 ` Tony Lindgren
2014-04-22 3:05 ` Tony Lindgren
2014-04-22 3:05 ` Tony Lindgren
2014-04-22 4:57 ` Tony Lindgren
2014-04-22 4:57 ` Tony Lindgren
2014-04-23 22:03 ` Rob Herring
2014-04-23 22:03 ` Rob Herring
2014-04-23 22:03 ` Rob Herring
2014-04-23 17:38 ` Russell King - ARM Linux
2014-04-23 17:38 ` Russell King - ARM Linux
2014-04-23 17:38 ` Russell King - ARM Linux
2014-04-23 15:02 ` Grant Likely
2014-04-23 15:02 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140418205213.GA21823@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.