From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] libsoxr: new package
Date: Sat, 19 Apr 2014 09:52:42 +0200 [thread overview]
Message-ID: <20140419095242.4f405cdd@skate> (raw)
In-Reply-To: <1397867553-7107-1-git-send-email-hadrien.boutteville@gmail.com>
Dear Hadrien Boutteville,
On Sat, 19 Apr 2014 02:32:33 +0200, Hadrien Boutteville wrote:
> Building tests fails mainly because of the cross-compilation, so they
> are disabled for the moment.
>
> Signed-off-by: Hadrien Boutteville <hadrien.boutteville@gmail.com>
Thanks, this is looking good. A few comments below.
> diff --git a/package/libsoxr/Config.in b/package/libsoxr/Config.in
> new file mode 100644
> index 0000000..ad6f8dd
> --- /dev/null
> +++ b/package/libsoxr/Config.in
> @@ -0,0 +1,16 @@
> +config BR2_PACKAGE_LIBSOXR
> + bool "libsoxr"
Really no toolchain dependencies? Can you test this package with the
following toolchain configurations:
http://autobuild.buildroot.org/toolchains/configs/free-electrons/bfin-linux-uclibc.config
-> this one tests !MMU
http://autobuild.buildroot.org/toolchains/configs/free-electrons/bfin-uclinux.config
-> this one tests !MMU and static library only
http://autobuild.buildroot.org/toolchains/configs/free-electrons/br-arm-full-nothread.config
-> this one tests the absence of thread support
http://autobuild.buildroot.org/toolchains/configs/free-electrons/br-arm-basic.config
-> and this one tests a minimal toolchain
> diff --git a/package/libsoxr/libsoxr.mk b/package/libsoxr/libsoxr.mk
> new file mode 100644
> index 0000000..c0fb72b
> --- /dev/null
> +++ b/package/libsoxr/libsoxr.mk
> @@ -0,0 +1,24 @@
> +################################################################################
> +#
> +# libsoxr
> +#
> +################################################################################
> +
> +LIBSOXR_VERSION = 0.1.1
> +LIBSOXR_SITE = git://git.code.sf.net/p/soxr/code
The project apparently provides a tarball. Could you use the tarball
instead of the Git repository?
> +LIBSOXR_LICENSE = LGPLv2.1
According to the LICENSE file, the license is LGPLv2.1+
> +LIBSOXR_LICENSE_FILES = LICENCE COPYING.LGPL
> +LIBSOXR_INSTALL_STAGING = YES
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-04-19 7:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-19 0:32 [Buildroot] [PATCH 1/1] libsoxr: new package Hadrien Boutteville
2014-04-19 7:02 ` Thomas De Schampheleire
2014-04-19 7:52 ` Thomas Petazzoni [this message]
2014-04-19 10:49 ` Hadrien Boutteville
2014-04-19 12:06 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140419095242.4f405cdd@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.