From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] apr: add missing comment about needed dynamic library support
Date: Sat, 19 Apr 2014 19:00:56 +0200 [thread overview]
Message-ID: <20140419190056.1bd35326@skate> (raw)
In-Reply-To: <1397860214-30560-1-git-send-email-zinosat@tiscali.it>
Dear Davide Viti,
On Sat, 19 Apr 2014 00:30:14 +0200, Davide Viti wrote:
> From: Davide Viti <d.viti@infosolution.it>
>
> Signed-off-by: Davide Viti <d.viti@infosolution.it>
> ---
> package/apr/Config.in | 4 ++++
> 1 file changed, 4 insertions(+)
Applied, thanks, but I had to fix something:
> diff --git a/package/apr/Config.in b/package/apr/Config.in
> index e06d254..73a4482 100644
> --- a/package/apr/Config.in
> +++ b/package/apr/Config.in
> @@ -9,3 +9,7 @@ config BR2_PACKAGE_APR
> consistent interface to underlying platform-specific implementations
>
> http://apr.apache.org/
> +
> +comment "apr needs a toolchain w/ dynamic library"
> + depends on !BR2_USE_MMU
This should have been "depends on BR2_USE_MMU". The apr package is only
available on architectures having an MMU. So there's no point in
displaying the comment if we're on an MMU-less platform.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2014-04-19 17:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-18 22:30 [Buildroot] [PATCH 1/1] apr: add missing comment about needed dynamic library support Davide Viti
2014-04-19 17:00 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140419190056.1bd35326@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.