From: Willy Tarreau <w@1wt.eu>
To: Bastien Armand <armand.bastien@laposte.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Monam Agarwal <monamagarwal123@gmail.com>,
Jake Champlin <jake.champlin.27@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] staging: panel: fix sparse warnings.
Date: Sun, 20 Apr 2014 08:24:37 +0200 [thread overview]
Message-ID: <20140420062437.GB4037@1wt.eu> (raw)
In-Reply-To: <20140418160918.GA1258@plop.dartybox.com>
Hi Bastien,
On Fri, Apr 18, 2014 at 06:09:18PM +0200, Bastien Armand wrote:
> This serie of two patch fix the following sparse warnings in panel.c :
> panel.c:1235:26: warning: incorrect type in argument 1 (different address spaces)
> panel.c:1235:26: expected void const volatile [noderef] <asn:1>*<noident>
> panel.c:1235:26: got char const *tmp
> panel.c:1353:20: warning: incorrect type in initializer (incompatible argument 2 (different address spaces))
> panel.c:1353:20: expected int ( *write )( ... )
> panel.c:1353:20: got int ( static [toplevel] *<noident> )( ... )
> panel.c:1591:17: warning: incorrect type in argument 1 (different address spaces)
> panel.c:1591:17: expected void const volatile [noderef] <asn:1>*<noident>
> panel.c:1591:17: got char *tmp
> panel.c:1620:20: warning: incorrect type in initializer (incompatible argument 2 (different address spaces))
> panel.c:1620:20: expected int ( *read )( ... )
> panel.c:1620:20: got int ( static [toplevel] *<noident> )( ... )
>
> Changes since v1 :
> - splitted patch in two
>
> Bastien Armand (2):
> staging: panel: fix sparse warnings in keypad_read
> staging: panel: fix sparse warnings in lcd_write
Just reviewed them both and I'm fine with these patches. You can
add my :
Acked-by: Willy Tarreau <w@1wt.eu>
Willy
prev parent reply other threads:[~2014-04-20 6:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-18 16:09 [PATCH v2 0/2] staging: panel: fix sparse warnings Bastien Armand
2014-04-20 6:24 ` Willy Tarreau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140420062437.GB4037@1wt.eu \
--to=w@1wt.eu \
--cc=armand.bastien@laposte.net \
--cc=arnd@arndb.de \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jake.champlin.27@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=monamagarwal123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.