All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] grub2: add configuration options for grub config files
Date: Sun, 20 Apr 2014 17:51:59 +0200	[thread overview]
Message-ID: <20140420175159.591f1714@skate> (raw)
In-Reply-To: <1396600337-26228-1-git-send-email-dmitriyz@google.com>

Dear Dima Zavin,

On Fri,  4 Apr 2014 01:32:17 -0700, Dima Zavin wrote:
> Add an option for embedding a config file directly in grub as
> well as an option to provide a custom grub.cfg file through
> a defconfig.
> 
> Signed-off-by: Dima Zavin <dmitriyz@google.com>
> ---
>  boot/grub2/Config.in | 12 ++++++++++++
>  boot/grub2/grub2.mk  |  8 +++++++-
>  2 files changed, 19 insertions(+), 1 deletion(-)

I've applied your patch, but:

 * I've removed the BR2_TARGET_GRUB2_CONFIG option, because the same
   thing can be achieved using a post-build script or a rootfs overlay.
   We don't have options in each and every package that can use a
   custom configuration, so I don't really see a reason to have this
   for Grub2 specifically.

 * I've reworded the Config.in help for the built-in configuration file
   option.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2014-04-20 15:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-04  8:32 [Buildroot] [PATCH] grub2: add configuration options for grub config files Dima Zavin
2014-04-11  4:12 ` Dima Zavin
2014-04-20 15:51 ` Thomas Petazzoni [this message]
2014-04-20 16:05   ` Dima Zavin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140420175159.591f1714@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.