From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [RFC] pkg-autotools: check if host-pkgconf should be part of the dependencies
Date: Mon, 21 Apr 2014 22:29:01 +0200 [thread overview]
Message-ID: <20140421222901.52941bf8@skate> (raw)
In-Reply-To: <20140421201610.GJ3359@free.fr>
Dear Yann E. MORIN,
On Mon, 21 Apr 2014 22:16:10 +0200, Yann E. MORIN wrote:
> > +define CHECK_PKG_CONFIG_HOOK
> > + $(Q)if grep -q PKG_CHECK_MODULES $$($$(PKG)_SRCDIR)/configure.{ac,in}; then \
>
> I know we do not support building on anything but a GNU userland.
> However, 'grep -q' is not portable. Can we just use the more poprtable
> constrcut 'grep ... >/dev/null 2>&1' instead?
Hum, well, will we ever run on anything but a GNU userland? We already
have tons of "grep -q" usage everywhere in the tree.
But anyway, I'll leave that up to Peter, I'm not going to merge myself
such a change that I've written myself.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-04-21 20:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-21 18:38 [Buildroot] [RFC] pkg-autotools: check if host-pkgconf should be part of the dependencies Thomas Petazzoni
2014-04-21 20:16 ` Yann E. MORIN
2014-04-21 20:29 ` Thomas Petazzoni [this message]
2014-04-22 16:33 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140421222901.52941bf8@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.