From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-ext4@vger.kernel.org, xfs@oss.sgi.com,
Eric Whitney <enwlinux@gmail.com>
Subject: Re: [PATCH 1/3] xfstests: add helper for zero range support check
Date: Tue, 22 Apr 2014 19:14:43 +1000 [thread overview]
Message-ID: <20140422091443.GG15995@dastard> (raw)
In-Reply-To: <20140422062816.GB31337@infradead.org>
On Mon, Apr 21, 2014 at 11:28:16PM -0700, Christoph Hellwig wrote:
> > +# check that xfs_io, kernel, and filesystem all support fallocate with zero
> > +# range
> > +_require_xfs_io_falloc_zero()
> > +{
> > + _require_xfs_io_command "fzero"
> > +}
>
> I'd rather remove all the wrappers around _require_xfs_io_command, they
> don't actually add any value.
I don't really care either way, as long as all the checks are done
consistently. Send a patch to change them all... :)
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-04-22 9:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-21 20:40 [PATCH 1/3] xfstests: add helper for zero range support check Eric Whitney
2014-04-22 6:28 ` Christoph Hellwig
2014-04-22 6:28 ` Christoph Hellwig
2014-04-22 9:14 ` Dave Chinner [this message]
2014-04-22 9:16 ` Christoph Hellwig
2014-04-22 9:16 ` Christoph Hellwig
2014-04-22 9:28 ` Lukáš Czerner
2014-04-22 9:28 ` Lukáš Czerner
2014-04-22 9:46 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140422091443.GG15995@dastard \
--to=david@fromorbit.com \
--cc=enwlinux@gmail.com \
--cc=hch@infradead.org \
--cc=linux-ext4@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.