From: Dan Carpenter <dan.carpenter@oracle.com>
To: navin patidar <navin.patidar@gmail.com>
Cc: gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/10] staging: rtl8188eu: Remove _ReadLEDSetting() function.
Date: Tue, 22 Apr 2014 13:11:01 +0300 [thread overview]
Message-ID: <20140422101101.GG26890@mwanda> (raw)
In-Reply-To: <1397983638-10752-3-git-send-email-navin.patidar@gmail.com>
On Sun, Apr 20, 2014 at 02:17:11PM +0530, navin patidar wrote:
> _ReadLEDSetting() doesn't read led settings this function actually
> initialize member variables of struct led_priv, we should do that
> inside rtl8188eu_InitSwLeds().
>
This seems like a bugfix or is it just a cleanup? It's not clear to me
from the patch description. Have you tested this patch?
regards,
dan carpenter
next prev parent reply other threads:[~2014-04-22 10:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-20 8:47 [PATCH 01/10] staging: rtl8188eu: Remove empty header file navin patidar
2014-04-20 8:47 ` [PATCH 02/10] staging: rtl8188eu: Remove rtw_led_blink_cmd() function navin patidar
2014-04-20 8:47 ` [PATCH 03/10] staging: rtl8188eu: Remove _ReadLEDSetting() function navin patidar
2014-04-22 10:11 ` Dan Carpenter [this message]
2014-04-22 14:01 ` navin patidar
2014-04-22 14:14 ` Dan Carpenter
2014-04-22 14:28 ` Larry Finger
2014-04-22 14:49 ` Dan Carpenter
2014-04-23 3:45 ` navin patidar
2014-04-20 8:47 ` [PATCH 04/10] staging: rtl8188eu: Remove _InitHWLed() function navin patidar
2014-04-20 8:47 ` [PATCH 05/10] staging: rtl8188eu: Simplify led blinking strategy code navin patidar
2014-04-22 10:21 ` Dan Carpenter
2014-04-20 8:47 ` [PATCH 06/10] staging: rtl8188eu: Remove enum LED_STRATEGY_871x navin patidar
2014-04-20 8:47 ` [PATCH 07/10] staging: rtl8188eu: refactor led related structures navin patidar
2014-04-20 8:47 ` [PATCH 08/10] staging: rtl8188eu: Remove unused macros navin patidar
2014-04-20 8:47 ` [PATCH 09/10] staging: rtl8188eu: Remove unused enum LED_STATE_871x members navin patidar
2014-04-22 10:35 ` Dan Carpenter
2014-04-23 3:31 ` navin patidar
2014-04-23 8:37 ` Dan Carpenter
2014-04-20 8:47 ` [PATCH 10/10] staging: rtl8188eu: Remove unused enum LED_CTL_MODE members navin patidar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140422101101.GG26890@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=navin.patidar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.