From: Dave Jones <davej@redhat.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux-Fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] vfs: rw_copy_check_uvector() - free iov on error
Date: Tue, 22 Apr 2014 09:38:35 -0400 [thread overview]
Message-ID: <20140422133835.GA32718@redhat.com> (raw)
In-Reply-To: <CAJfpegs9cgVgxbYZSM=SxyJqj=N1QA5npp7ic6i80CMec+3sZw@mail.gmail.com>
On Tue, Apr 22, 2014 at 10:42:52AM +0200, Miklos Szeredi wrote:
> > > Your patch looks a lot more complete than the quick hack I did a few
> > > days ago when coverity first started nagging about this, but in testing
> > > I've found that something really ugly starts showing up when you patch this
> > >
> > > The symptoms vary, but always are some kind of slab corruption.
> > > Here's the last example:
> > >
> > > The crash happens very quickly (within a few seconds of running trinity) for me.
> >
> > Al, Miklos ?
>
> I probably am blind, but I can't see how that will cause slab corruption.
>
> Have you verified that it's just that single patch and no other change?
yeah, runs a lot longer (before eventually hitting other issues) without
the patch.
Dave
next prev parent reply other threads:[~2014-04-22 13:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-15 14:57 [PATCH] vfs: rw_copy_check_uvector() - free iov on error Miklos Szeredi
2014-04-16 18:04 ` Dave Jones
2014-04-21 15:50 ` Dave Jones
2014-04-22 8:42 ` Miklos Szeredi
2014-04-22 13:38 ` Dave Jones [this message]
2014-04-23 5:06 ` Eric Biggers
2014-04-23 5:25 ` Eric Biggers
2014-04-25 16:27 ` Miklos Szeredi
2014-04-25 16:25 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140422133835.GA32718@redhat.com \
--to=davej@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.