All of lore.kernel.org
 help / color / mirror / Atom feed
From: chrubis@suse.cz
To: Mats Liljegren <mats.liljegren@enea.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] Make SAFE_* calls more informative when failing
Date: Tue, 22 Apr 2014 15:41:50 +0200	[thread overview]
Message-ID: <20140422134150.GC3951@rei> (raw)
In-Reply-To: <1397669278-848-2-git-send-email-mats.liljegren@enea.com>

Hi!
> The output has been "standardized" into the following format:
> <file>:<line>: <func>(<params>) <error message>
> 
> E.g.:
> test.c:130: chdir(mydir) failed
> 
> This will then be followed by the usual errno stuff if applicable.

I've also unified conding style for the file and fixed a minor things
(use octal instead of decimal for creat() mode, the symlink error
message said link() instead of symlink(), etc.) and pushed these an one
commit, thanks.

PS: I've also decided to print open() mode regardless if it's used or
    not, which is IMHO better than not printing it at all.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Start Your Social Network Today - Download eXo Platform
Build your Enterprise Intranet with eXo Platform Software
Java Based Open Source Intranet - Social, Extensible, Cloud Ready
Get Started Now And Turn Your Intranet Into A Collaboration Platform
http://p.sf.net/sfu/ExoPlatform
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

  reply	other threads:[~2014-04-22 13:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-16  7:15 [LTP] More informative error messages from SAFE_*? Mats Liljegren
2014-04-16 15:52 ` chrubis
2014-04-16 17:27 ` [LTP] [PATCH] Make SAFE_* calls more informative when failing Mats Liljegren
2014-04-16 17:27   ` Mats Liljegren
2014-04-22 13:41     ` chrubis [this message]
2014-04-22 13:24   ` Mats Liljegren
2014-04-22 13:42     ` chrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140422134150.GC3951@rei \
    --to=chrubis@suse.cz \
    --cc=ltp-list@lists.sourceforge.net \
    --cc=mats.liljegren@enea.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.