From: Guenter Roeck <linux@roeck-us.net>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH v3] hwmon: (lm77) Do not preserve hysteresis when updating critical temp lim
Date: Tue, 22 Apr 2014 15:08:55 +0000 [thread overview]
Message-ID: <20140422150855.GA20271@roeck-us.net> (raw)
In-Reply-To: <20140422112641.GA15567@roeck-us.net>
On Tue, Apr 22, 2014 at 04:32:58PM +0200, Jean Delvare wrote:
> On Tue, 22 Apr 2014 04:26:41 -0700, Guenter Roeck wrote:
> > Updating the hysteresis value when updating the critical temperature limit
> > was following the rule of 'least surprise'. However, it had the undesirable
> > side effect of changing the hysteresis for all other attributes, which
> > defeats the purpose of least surprise. In addition, it could result in
> > invalid hysteresis values if the resulting hysteresis was too large. In such
> > cases the resulting hysteresis ended up changed anyway, which again defeats
> > the purpose. So drop that code and document the new behavior.
> >
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> > ---
> > v3: Replace documentation with text suggested by Jean
> > Drop obsolete comment
> > v2: Move this patch ahead of subsequent patches to simplify those
> >
> > Documentation/hwmon/lm77 | 20 ++++++++++++++++++--
> > drivers/hwmon/lm77.c | 6 ------
> > 2 files changed, 18 insertions(+), 8 deletions(-)
> > (...)
>
> Reviewed-by: Jean Delvare <jdelvare@suse.de>
>
Thanks a lot for the reviews and your time!
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
prev parent reply other threads:[~2014-04-22 15:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 11:26 [lm-sensors] [PATCH v3] hwmon: (lm77) Do not preserve hysteresis when updating critical temp limit Guenter Roeck
2014-04-22 14:32 ` [lm-sensors] [PATCH v3] hwmon: (lm77) Do not preserve hysteresis when updating critical temp lim Jean Delvare
2014-04-22 15:08 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140422150855.GA20271@roeck-us.net \
--to=linux@roeck-us.net \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.