All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: David Decotigny <decot@googlers.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2 v1] iproute2: show counter of carrier on<->off transitions
Date: Tue, 22 Apr 2014 15:46:16 -0700	[thread overview]
Message-ID: <20140422154616.4e4eb445@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <6c78808eaf4b31f98c9de9bef6f29397c67cf09e.1396455409.git.decot@googlers.com>

On Wed,  2 Apr 2014 09:19:00 -0700
David Decotigny <decot@googlers.com> wrote:

> This patch allows to display the current counter of carrier on<->off
> transitions (IFLA_CARRIER_CHANGES, see kernel commit "expose number of
> carrier on/off changes"):
> 
>   ip -s -s link show dev eth0
>   ...
>   2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 etc.
>     link/ether ............ brd ff:ff:ff:ff:ff:ff
>     RX: bytes  packets  errors  dropped overrun mcast
>     134705     758      0       0       0       0
>     RX errors: length  crc     frame   fifo    missed
>                0        0       0       0       0
>     TX: bytes  packets  errors  dropped carrier collsns
>     77374      731      0       0       0       0
>     TX errors: aborted fifo    window  heartbeat
>                0        0       0       0
>     link: carrier_changes 4
> 

I wonder if putting it under TX errors would make sense.
This is where Juniper classifies the error, and it would also
fit on same line, avoiding adding more clutter.


   2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 etc.
     link/ether ............ brd ff:ff:ff:ff:ff:ff
     RX: bytes  packets  errors  dropped overrun mcast
     134705     758      0       0       0       0
     RX errors: length  crc     frame   fifo    missed
                0        0       0       0       0
     TX: bytes  packets  errors  dropped carrier collsns
     77374      731      0       0       0       0
     TX errors: aborted fifo    window  heartbeat transition
                0        0       0       0        4

The risk is break some screen scraping script, but that doesn't
seem to be that big an issue for adding one column.

The columns also need some re-aligning here but that is different
correctness issue.

      reply	other threads:[~2014-04-22 22:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1396455409.git.decot@googlers.com>
2014-04-02 16:19 ` [PATCH iproute2 v1] iproute2: show counter of carrier on<->off transitions David Decotigny
2014-04-22 22:46   ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140422154616.4e4eb445@nehalam.linuxnetplumber.net \
    --to=stephen@networkplumber.org \
    --cc=decot@googlers.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.