From: Arnd Bergmann <arnd@arndb.de>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "'linux-pci'" <linux-pci@vger.kernel.org>,
"'Bjorn Helgaas'" <bhelgaas@google.com>,
linux-arm-kernel@lists.infradead.org,
linaro-kernel@lists.linaro.org, linux-kernel@vger.kernel.org,
"'Liviu Dudau'" <Liviu.Dudau@arm.com>,
"'Kukjin Kim'" <kgene.kim@samsung.com>
Subject: Re: [RFC PATCH 2/2] PCI: exynos: Add PCIe support for Samsung GH7 SoC
Date: Tue, 22 Apr 2014 16:11:39 +0200 [thread overview]
Message-ID: <201404221611.40087.arnd@arndb.de> (raw)
In-Reply-To: <000a01cf592e$67e592e0$37b0b8a0$%han@samsung.com>
On Wednesday 16 April 2014, Jingoo Han wrote:
> Samsung GH7 has four PCIe controllers which can be used as root
> complex for PCIe interface.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/pci/host/Kconfig | 2 +-
> drivers/pci/host/pci-exynos.c | 135 ++++++++++++++++++++++++++++++++++++++---
> 2 files changed, 126 insertions(+), 11 deletions(-)
Can you explain how much the GH7 and Exynos front-ends actually have in
common? Would it make sense to have a separate driver for gh7?
Also, if gh7 is expected to run a full firmware, I think you should
do all the setup in the firmware before booting Linux, and just
do the required run-time operations in the driver itself.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 2/2] PCI: exynos: Add PCIe support for Samsung GH7 SoC
Date: Tue, 22 Apr 2014 16:11:39 +0200 [thread overview]
Message-ID: <201404221611.40087.arnd@arndb.de> (raw)
In-Reply-To: <000a01cf592e$67e592e0$37b0b8a0$%han@samsung.com>
On Wednesday 16 April 2014, Jingoo Han wrote:
> Samsung GH7 has four PCIe controllers which can be used as root
> complex for PCIe interface.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/pci/host/Kconfig | 2 +-
> drivers/pci/host/pci-exynos.c | 135 ++++++++++++++++++++++++++++++++++++++---
> 2 files changed, 126 insertions(+), 11 deletions(-)
Can you explain how much the GH7 and Exynos front-ends actually have in
common? Would it make sense to have a separate driver for gh7?
Also, if gh7 is expected to run a full firmware, I think you should
do all the setup in the firmware before booting Linux, and just
do the required run-time operations in the driver itself.
Arnd
next prev parent reply other threads:[~2014-04-22 14:11 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 4:41 [RFC PATCH 0/2] Add support for Samsung GH7 PCIe controller Jingoo Han
2014-04-16 4:41 ` Jingoo Han
2014-04-16 4:42 ` [RFC PATCH 1/2] PCI: designware: Add ARM64 PCI support Jingoo Han
2014-04-16 4:42 ` Jingoo Han
2014-04-16 16:57 ` Liviu Dudau
2014-04-16 16:57 ` Liviu Dudau
2014-04-16 18:26 ` Arnd Bergmann
2014-04-16 18:26 ` Arnd Bergmann
2014-04-21 1:54 ` Jingoo Han
2014-04-21 1:54 ` Jingoo Han
2014-04-21 9:58 ` Jingoo Han
2014-04-21 9:58 ` Jingoo Han
2014-04-22 13:01 ` Liviu Dudau
2014-04-22 13:01 ` Liviu Dudau
2014-04-22 15:39 ` Rob Herring
2014-04-22 15:39 ` Rob Herring
2014-04-22 12:59 ` Liviu Dudau
2014-04-22 12:59 ` Liviu Dudau
2014-04-22 12:54 ` Liviu Dudau
2014-04-22 12:54 ` Liviu Dudau
2014-04-16 4:43 ` [RFC PATCH 2/2] PCI: exynos: Add PCIe support for Samsung GH7 SoC Jingoo Han
2014-04-16 4:43 ` Jingoo Han
2014-04-22 14:11 ` Arnd Bergmann [this message]
2014-04-22 14:11 ` Arnd Bergmann
2014-04-23 9:19 ` Kukjin Kim
2014-04-23 9:19 ` Kukjin Kim
2014-04-23 11:03 ` Arnd Bergmann
2014-04-23 11:03 ` Arnd Bergmann
2014-04-23 14:23 ` Liviu Dudau
2014-04-23 14:23 ` Liviu Dudau
2014-04-23 16:20 ` Arnd Bergmann
2014-04-23 16:20 ` Arnd Bergmann
2014-04-24 4:53 ` Kukjin Kim
2014-04-24 4:53 ` Kukjin Kim
2014-04-24 9:49 ` Arnd Bergmann
2014-04-24 9:49 ` Arnd Bergmann
2014-04-23 13:00 ` Liviu Dudau
2014-04-23 13:00 ` Liviu Dudau
2014-04-24 12:25 ` Arnd Bergmann
2014-04-24 12:25 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201404221611.40087.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=Liviu.Dudau@arm.com \
--cc=bhelgaas@google.com \
--cc=jg1.han@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.