From: Dan Carpenter <dan.carpenter@oracle.com>
To: Fabio Falzoi <fabio.falzoi84@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/6] Staging: rts5139: Use standard pr_<level> prefixing
Date: Wed, 23 Apr 2014 01:07:57 +0300 [thread overview]
Message-ID: <20140422220757.GQ26890@mwanda> (raw)
In-Reply-To: <1398201784-7602-5-git-send-email-fabio.falzoi84@gmail.com>
On Tue, Apr 22, 2014 at 11:23:02PM +0200, Fabio Falzoi wrote:
> Define pr_fmt macro to prefix every pr_<level> function in standard way.
>
In the end we will want to remove all these debugging messages. The
error conditions probably already have a print, the function tracing is
done better with ftrace, etc.
Also the pr_ functions have fallen out of fashion and all the cool kids
use dev_ prefixed printks now. (Doesn't really apply to this patch per
se).
regards,
dan carpenter
next prev parent reply other threads:[~2014-04-22 22:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 21:22 [PATCH v3 0/6] Staging: rts5139: Fix coding style Fabio Falzoi
2014-04-22 21:22 ` [PATCH v3 1/6] Staging: rts5139: Camel case labels replaced Fabio Falzoi
2014-04-22 22:03 ` Dan Carpenter
2014-04-22 21:23 ` [PATCH v3 2/6] Staging: rts5139: Fixed multi-line code alignment Fabio Falzoi
2014-04-22 21:23 ` [PATCH v3 3/6] Staging: rts5139: Splitted one-line multiple assignment Fabio Falzoi
2014-04-22 21:23 ` [PATCH v3 4/6] Staging: rts5139: Use standard pr_<level> prefixing Fabio Falzoi
2014-04-22 22:07 ` Dan Carpenter [this message]
2014-04-22 22:10 ` Dan Carpenter
2014-04-22 21:23 ` [PATCH v3 5/6] Staging: rts5139: Removed OOM messages Fabio Falzoi
2014-04-22 21:23 ` [PATCH v3 6/6] Staging: rts5139: More appropriate use of sizeof operand Fabio Falzoi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140422220757.GQ26890@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=fabio.falzoi84@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.