From: Greg Rose <gregory.v.rose@intel.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: <netdev@vger.kernel.org>, <ssujith@cisco.com>,
<neepatel@cisco.com>, <benve@cisco.com>, <davem@davemloft.net>,
<ben@decadent.org.uk>, <govindarajulu90@gmail.com>
Subject: Re: [0/2] Fix problems with with IFLA_VF_PORTS
Date: Wed, 23 Apr 2014 08:14:15 -0700 [thread overview]
Message-ID: <20140423081415.000025af@unknown> (raw)
In-Reply-To: <1398237665-26980-1-git-send-email-david@gibson.dropbear.id.au>
On Wed, 23 Apr 2014 17:21:03 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:
> I've had a customer encounter a problem with getifaddrs(3) freezing up
> on a system with a Cisco enic device.
>
> I've discovered that the problem is caused by an enic device with a
> large number of SR-IOV virtual functions overflowing the normal sized
> packet buffer for netlink, leading to interfaces not being reported
> from an RTM_GETLINK request.
>
> The first patch here just makes the problem easier to locate if it
> occurs again in a different way, by adding a WARN_ON() when we run out
> of room in a netlink packet in this manner.
>
> The second patch actually fixes the problem, by only reporting
> IFLA_VF_PORTS information when the RTEXT_FILTER_VF flag is specified.
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Once you fix a couple of coding style errors mentioned by Jiri then
Acked-by: Greg Rose <gregory.v.rose@intel.com>
prev parent reply other threads:[~2014-04-23 15:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-23 7:21 [0/2] Fix problems with with IFLA_VF_PORTS David Gibson
2014-04-23 7:21 ` [PATCH 1/2] rtnetlink: Warn when interface's information won't fit in our packet David Gibson
2014-04-23 9:09 ` Jiri Pirko
2014-04-23 11:41 ` David Gibson
2014-04-23 11:51 ` Jiri Pirko
2014-04-23 14:20 ` Sergei Shtylyov
2014-04-23 7:21 ` [PATCH 2/2] rtnetlink: Only supply IFLA_VF_PORTS information when RTEXT_FILTER_VF is set David Gibson
2014-04-23 9:17 ` Jiri Pirko
2014-04-24 0:13 ` David Gibson
2014-04-23 15:14 ` Greg Rose [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140423081415.000025af@unknown \
--to=gregory.v.rose@intel.com \
--cc=ben@decadent.org.uk \
--cc=benve@cisco.com \
--cc=davem@davemloft.net \
--cc=david@gibson.dropbear.id.au \
--cc=govindarajulu90@gmail.com \
--cc=neepatel@cisco.com \
--cc=netdev@vger.kernel.org \
--cc=ssujith@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.