From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH] xen: use XEN_BOOT_DIR as xen.gz install
	location
Date: Wed, 23 Apr 2014 11:39:22 +0200
Message-ID: <20140423093922.GA1191@aepfle.de>
References: <1398240022-17570-1-git-send-email-olaf@aepfle.de>
	<5357A558020000780000B40E@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <5357A558020000780000B40E@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: keir@xen.org, tim@xen.org, ian.jackson@eu.citrix.com, ian.campbell@citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Wed, Apr 23, Jan Beulich wrote:

> >>> On 23.04.14 at 10:00, <olaf@aepfle.de> wrote:
> > --- a/xen/Makefile
> > +++ b/xen/Makefile
> > @@ -13,6 +13,7 @@ export BASEDIR := $(CURDIR)
> >  export XEN_ROOT := $(BASEDIR)/..
> >  
> >  EFI_MOUNTPOINT ?= /boot/efi
> > +XEN_BOOT_DIR ?= /boot
> 
> Did it not occur to you that the immediately preceding line then
> would also need changing? I'm also not certain about the need for
> the XEN_ prefix on the new variable - there's nothing Xen-specific
> about the location of the boot directory/partition.

Why would EFI_MOUNTPOINT need a change? If it does not fit it can be
changed at build time. But I'm fine with something like

BOOT_DIR ?= /boot
EFI_MOUNTPOINT ?= $(BOOT_DIR)/efi

Olaf