Re: [PATCH v3] mfd: syscon: Support early initialization

[Lee Jones <lee.jones@linaro.org>]

> >>> Some platforms need to get system controller
> >>> ready as soon as possible.
> >>> The patch provides early_syscon_initialization
> >>> which create early mapping for all syscon compatible
> >>> devices in early_syscon_probe.
> >>> Regmap is get via syscon_early_regmap_lookup_by_phandle()
> >>>
> >>> Regular device probes attach device to regmap
> >>> via regmap_attach_dev().
> >>>
> >>> For early syscon initialization is necessary to extend
> >>> struct syscon and provide remove function
> >>> which unmap all early init structures.
> >>>
> >>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> >>> ---
> >>>
> >>> Changes in v3:
> >>> - Keep backward compatibility for platform drivers and test it
> >>> - Use only one probe method which is early_syscon_probe
> >>>    suggested by Lee Jones. Do not force anybody to call early_syscon_init
> >>> - Add kernel-doc description
> >>>
> >>> Changes in v2:
> >>> - Fix bad logic in early_syscon_probe
> >>> - Fix compilation failure for x86_64 reported by zero day testing system
> >>> - Regmap change available here
> >>>    git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git tags/nodev
> >>>
> >>>   drivers/mfd/syscon.c       | 159 ++++++++++++++++++++++++++++++++++++++++-----
> >>>   include/linux/mfd/syscon.h |  11 ++++
> >>>   2 files changed, 153 insertions(+), 17 deletions(-)

> Lee: Can you please look at these changes?  It is around for a while
> and I would like to close it. 

Actually I'm _still_ waiting on Arnd and Mark's opinion on this, as my
reservations from v1 still apply.

  https://lkml.org/lkml/2014/2/12/149

I'll poke them now.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog