From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] reset: Add of_reset_control_get to reset.h
Date: Wed, 23 Apr 2014 14:27:50 +0200 [thread overview]
Message-ID: <20140423122750.GP24905@lukather> (raw)
In-Reply-To: <1397462286.3800.2.camel@paszta.hi.pengutronix.de>
Hi Philipp,
On Mon, Apr 14, 2014 at 09:58:06AM +0200, Philipp Zabel wrote:
> Am Sonntag, den 13.04.2014, 14:09 +0200 schrieb Hans de Goede:
> > of_reset_control_get is not declared static in drivers/reset/core.c, which
> > is correct as we want to use it elsewhere too. But it does not have a
> > protype declared anywhere under include/linux. Add a prototype / stub for it
> > to linux/reset.h to fix this.
> >
> > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> > ---
> > include/linux/reset.h | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/include/linux/reset.h b/include/linux/reset.h
> > index c0eda50..f1ae7ce 100644
> > --- a/include/linux/reset.h
> > +++ b/include/linux/reset.h
> > @@ -33,6 +33,9 @@ static inline struct reset_control *devm_reset_control_get_optional(
> > return devm_reset_control_get(dev, id);
> > }
> >
> > +struct reset_control *of_reset_control_get(struct device_node *node,
> > + const char *id);
> > +
> > #else
> >
> > static inline int reset_control_reset(struct reset_control *rstc)
> > @@ -75,6 +78,12 @@ static inline struct reset_control *devm_reset_control_get_optional(
> > return ERR_PTR(-ENOSYS);
> > }
> >
> > +static inline struct reset_control *of_reset_control_get(
> > + struct device_node *node, const char *id)
> > +{
> > + return ERR_PTR(-ENOSYS);
> > +}
> > +
> > #endif /* CONFIG_RESET_CONTROLLER */
> >
> > #endif
>
> Applied, thanks.
I just noticed you queued this patch up for 3.16.
Since that function got introduced in 3.15-rc1, maybe it would be
better if you queued it for one of 3.15-rc* ?
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140423/e3d3819a/attachment.sig>
next prev parent reply other threads:[~2014-04-23 12:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-13 12:09 [PATCH] reset: Add of_reset_control_get to reset.h Hans de Goede
2014-04-13 12:47 ` Josh Triplett
2014-04-14 7:58 ` Philipp Zabel
2014-04-23 12:27 ` Maxime Ripard [this message]
2014-04-30 8:29 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140423122750.GP24905@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.