From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Revert "build: Use filechk rules to create and update u-boot.lds"
Date: Wed, 23 Apr 2014 08:45:51 -0400 [thread overview]
Message-ID: <20140423124551.GA6069@bill-the-cat> (raw)
In-Reply-To: <1398047587-20247-1-git-send-email-yamada.m@jp.panasonic.com>
On Mon, Apr 21, 2014 at 11:33:07AM +0900, Masahiro Yamada wrote:
> This reverts commit a8b993eb81c142a439c24b871a2317f765fe5397.
>
> Commit a8b993eb claims it fixes u-boot.lds rule by replacing
> $(call if_changed) with $(call filechk).
>
> But the problem had already been fixed by commit 395e60cd
> a few days before commit a8b993eb was posted.
>
> There is no reason to apply commit a8b993eb. What is worse is
> $(call filechk) is too strong to fix the problem and looks weird.
>
> Date of the two patches:
>
> [1] commit 395e60cdc292dc0183c6867d34b43f14a373df55
> Author: Masahiro Yamada <yamada.m@jp.panasonic.com>
> AuthorDate: Wed Apr 9 20:10:43 2014 +0900
> Commit: Tom Rini <trini@ti.com>
> CommitDate: Fri Apr 11 10:08:42 2014 -0400
> replaces $(call if_changed) -> $(call if_changed_dep)
>
> [2] commit a8b993eb81c142a439c24b871a2317f765fe5397
> Author: Jon Loeliger <jon.loeliger@oracle.com>
> AuthorDate: Tue Apr 15 16:09:37 2014 -0500
> Commit: Tom Rini <trini@ti.com>
> CommitDate: Fri Apr 18 16:14:16 2014 -0400
> replaces $(call if_changed) -> $(call filechk)
>
> A conflict must have happened when applying [2], but somehow it was
> applied, sadly.
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Cc: Jon Loeliger <jon.loeliger@oracle.com>
> Cc: Andreas Bie?mann <andreas.devel@googlemail.com>
> Cc: Tom Rini <trini@ti.com>
Whoops, Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140423/918592b0/attachment.pgp>
prev parent reply other threads:[~2014-04-23 12:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-21 2:33 [U-Boot] [PATCH] Revert "build: Use filechk rules to create and update u-boot.lds" Masahiro Yamada
2014-04-21 14:35 ` Jon Loeliger
2014-04-22 1:32 ` Masahiro Yamada
2014-04-23 12:45 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140423124551.GA6069@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.