From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [RFC 3/3] asm-generic: Drop renameat syscall from default list Date: Wed, 23 Apr 2014 14:18:04 +0200 Message-ID: <201404231418.05174.arnd@arndb.de> References: <1398247687-13453-1-git-send-email-james.hogan@imgtec.com> <1398247687-13453-4-git-send-email-james.hogan@imgtec.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1398247687-13453-4-git-send-email-james.hogan-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org> Sender: linux-metag-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: James Hogan Cc: linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Vineet Gupta , Catalin Marinas , Will Deacon , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Mark Salter , Aurelien Jacquiot , linux-c6x-dev-jPsnJVOj+W6hPH1hqNUYSQ@public.gmane.org, Richard Kuo , linux-hexagon-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-metag-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jonas Bonn , linux-ZwoEplunGu2h2975yA52AaxOck334EZe@public.gmane.org, Chen Liqin , Lennox Wu , Chris Metcalf , Guan Xuetao List-Id: linux-arch.vger.kernel.org On Wednesday 23 April 2014, James Hogan wrote: > The new renameat2 syscall provides all the functionality provided by the > renameat syscall and adds flags, so future architectures won't need to > include renameat. > > Therefore drop the renameat syscall from the generic syscall list unless > __ARCH_WANT_RENAMEAT is defined by the architecture's unistd.h prior to > including asm-generic/unistd.h, and adjust all architectures using the > generic syscall list to define it so that no in-tree architectures are > affected. I should have read this one before replying to patch 2 ;-) > Signed-off-by: James Hogan > Cc: Arnd Bergmann > Cc: linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Cc: Vineet Gupta > Cc: Catalin Marinas > Cc: Will Deacon > Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > Cc: Mark Salter > Cc: Aurelien Jacquiot > Cc: linux-c6x-dev-jPsnJVOj+W6hPH1hqNUYSQ@public.gmane.org > Cc: Richard Kuo > Cc: linux-hexagon-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Cc: linux-metag-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Cc: Jonas Bonn > Cc: linux-ZwoEplunGu2h2975yA52AaxOck334EZe@public.gmane.org > Cc: Chen Liqin > Cc: Lennox Wu > Cc: Chris Metcalf > Cc: Guan Xuetao > --- > Is this the approach we want to take to keep the default syscall list > minimal? We could for example have made renameat2 use the renameat > syscall number for new arches, but it seemed best to leave a gap for new > arches to improve consistency of numbering. I think leaving the hole is best. > This patch is a no-op for arches in tree, so there's no harm for this to > wait for the v3.16 merge window. Sounds good. I guess I'll have to put this into my asm-generic tree then, unless I can get the nios2 maintainers to pick it up. If you don't mind, can you submit the first two patches to Linus directly? Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-metag" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from moutng.kundenserver.de ([212.227.126.130]:59774 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751798AbaDWMSo (ORCPT ); Wed, 23 Apr 2014 08:18:44 -0400 From: Arnd Bergmann Subject: Re: [RFC 3/3] asm-generic: Drop renameat syscall from default list Date: Wed, 23 Apr 2014 14:18:04 +0200 References: <1398247687-13453-1-git-send-email-james.hogan@imgtec.com> <1398247687-13453-4-git-send-email-james.hogan@imgtec.com> In-Reply-To: <1398247687-13453-4-git-send-email-james.hogan@imgtec.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-ID: <201404231418.05174.arnd@arndb.de> Sender: linux-arch-owner@vger.kernel.org List-ID: To: James Hogan Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Vineet Gupta , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, Mark Salter , Aurelien Jacquiot , linux-c6x-dev@linux-c6x.org, Richard Kuo , linux-hexagon@vger.kernel.org, linux-metag@vger.kernel.org, Jonas Bonn , linux@lists.openrisc.net, Chen Liqin , Lennox Wu , Chris Metcalf , Guan Xuetao Message-ID: <20140423121804.027yUYXLzL_W5MUl1WlAvt1DA-TXbxR2pmZ4c0bEOXY@z> On Wednesday 23 April 2014, James Hogan wrote: > The new renameat2 syscall provides all the functionality provided by the > renameat syscall and adds flags, so future architectures won't need to > include renameat. > > Therefore drop the renameat syscall from the generic syscall list unless > __ARCH_WANT_RENAMEAT is defined by the architecture's unistd.h prior to > including asm-generic/unistd.h, and adjust all architectures using the > generic syscall list to define it so that no in-tree architectures are > affected. I should have read this one before replying to patch 2 ;-) > Signed-off-by: James Hogan > Cc: Arnd Bergmann > Cc: linux-arch@vger.kernel.org > Cc: Vineet Gupta > Cc: Catalin Marinas > Cc: Will Deacon > Cc: linux-arm-kernel@lists.infradead.org > Cc: Mark Salter > Cc: Aurelien Jacquiot > Cc: linux-c6x-dev@linux-c6x.org > Cc: Richard Kuo > Cc: linux-hexagon@vger.kernel.org > Cc: linux-metag@vger.kernel.org > Cc: Jonas Bonn > Cc: linux@lists.openrisc.net > Cc: Chen Liqin > Cc: Lennox Wu > Cc: Chris Metcalf > Cc: Guan Xuetao > --- > Is this the approach we want to take to keep the default syscall list > minimal? We could for example have made renameat2 use the renameat > syscall number for new arches, but it seemed best to leave a gap for new > arches to improve consistency of numbering. I think leaving the hole is best. > This patch is a no-op for arches in tree, so there's no harm for this to > wait for the v3.16 merge window. Sounds good. I guess I'll have to put this into my asm-generic tree then, unless I can get the nios2 maintainers to pick it up. If you don't mind, can you submit the first two patches to Linus directly? Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Wed, 23 Apr 2014 14:18:04 +0200 Subject: [RFC 3/3] asm-generic: Drop renameat syscall from default list In-Reply-To: <1398247687-13453-4-git-send-email-james.hogan@imgtec.com> References: <1398247687-13453-1-git-send-email-james.hogan@imgtec.com> <1398247687-13453-4-git-send-email-james.hogan@imgtec.com> Message-ID: <201404231418.05174.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wednesday 23 April 2014, James Hogan wrote: > The new renameat2 syscall provides all the functionality provided by the > renameat syscall and adds flags, so future architectures won't need to > include renameat. > > Therefore drop the renameat syscall from the generic syscall list unless > __ARCH_WANT_RENAMEAT is defined by the architecture's unistd.h prior to > including asm-generic/unistd.h, and adjust all architectures using the > generic syscall list to define it so that no in-tree architectures are > affected. I should have read this one before replying to patch 2 ;-) > Signed-off-by: James Hogan > Cc: Arnd Bergmann > Cc: linux-arch at vger.kernel.org > Cc: Vineet Gupta > Cc: Catalin Marinas > Cc: Will Deacon > Cc: linux-arm-kernel at lists.infradead.org > Cc: Mark Salter > Cc: Aurelien Jacquiot > Cc: linux-c6x-dev at linux-c6x.org > Cc: Richard Kuo > Cc: linux-hexagon at vger.kernel.org > Cc: linux-metag at vger.kernel.org > Cc: Jonas Bonn > Cc: linux at lists.openrisc.net > Cc: Chen Liqin > Cc: Lennox Wu > Cc: Chris Metcalf > Cc: Guan Xuetao > --- > Is this the approach we want to take to keep the default syscall list > minimal? We could for example have made renameat2 use the renameat > syscall number for new arches, but it seemed best to leave a gap for new > arches to improve consistency of numbering. I think leaving the hole is best. > This patch is a no-op for arches in tree, so there's no harm for this to > wait for the v3.16 merge window. Sounds good. I guess I'll have to put this into my asm-generic tree then, unless I can get the nios2 maintainers to pick it up. If you don't mind, can you submit the first two patches to Linus directly? Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754244AbaDWMSs (ORCPT ); Wed, 23 Apr 2014 08:18:48 -0400 Received: from moutng.kundenserver.de ([212.227.126.130]:59774 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751798AbaDWMSo (ORCPT ); Wed, 23 Apr 2014 08:18:44 -0400 From: Arnd Bergmann To: James Hogan Subject: Re: [RFC 3/3] asm-generic: Drop renameat syscall from default list Date: Wed, 23 Apr 2014 14:18:04 +0200 User-Agent: KMail/1.12.2 (Linux/3.8.0-22-generic; KDE/4.3.2; x86_64; ; ) Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Vineet Gupta , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, Mark Salter , Aurelien Jacquiot , linux-c6x-dev@linux-c6x.org, Richard Kuo , linux-hexagon@vger.kernel.org, linux-metag@vger.kernel.org, Jonas Bonn , linux@openrisc.net, Chen Liqin , Lennox Wu , Chris Metcalf , Guan Xuetao References: <1398247687-13453-1-git-send-email-james.hogan@imgtec.com> <1398247687-13453-4-git-send-email-james.hogan@imgtec.com> In-Reply-To: <1398247687-13453-4-git-send-email-james.hogan@imgtec.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201404231418.05174.arnd@arndb.de> X-Provags-ID: V02:K0:iQ6iVNTDDVWhVCxee2E+xHnfPwx8sQzvbinRcPwqKwI cqEvTuONroj6fRwhPR2EvRUeW8SrMY4/oMf4T1B9rVzEsvXnGy ZwyCfqfFasvj+FgLTNcgVoxZOchtikU2wWYlZ+1l1EdiUUbiMo yyBl7AAeBvzSPXdWJ2Mr78/2YvxS6PSAB4j1USjIZeQ+cf3y6y J8eQJPQXiJyGCxRDDC2bBv+yvvRNgQk3VsRgSLMJ5MmH/etvnv ZhmbIScV6Z8IuUWmpf6oKSpduVz4p+sRAaP28jdNr2AXaxNyqP ftXdc9SisncaOvIGXmwbMybETA0vNXt5H51OgjODqG4NWwWYlz uhHW7biUlS7lhpt9Ao1A= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 23 April 2014, James Hogan wrote: > The new renameat2 syscall provides all the functionality provided by the > renameat syscall and adds flags, so future architectures won't need to > include renameat. > > Therefore drop the renameat syscall from the generic syscall list unless > __ARCH_WANT_RENAMEAT is defined by the architecture's unistd.h prior to > including asm-generic/unistd.h, and adjust all architectures using the > generic syscall list to define it so that no in-tree architectures are > affected. I should have read this one before replying to patch 2 ;-) > Signed-off-by: James Hogan > Cc: Arnd Bergmann > Cc: linux-arch@vger.kernel.org > Cc: Vineet Gupta > Cc: Catalin Marinas > Cc: Will Deacon > Cc: linux-arm-kernel@lists.infradead.org > Cc: Mark Salter > Cc: Aurelien Jacquiot > Cc: linux-c6x-dev@linux-c6x.org > Cc: Richard Kuo > Cc: linux-hexagon@vger.kernel.org > Cc: linux-metag@vger.kernel.org > Cc: Jonas Bonn > Cc: linux@lists.openrisc.net > Cc: Chen Liqin > Cc: Lennox Wu > Cc: Chris Metcalf > Cc: Guan Xuetao > --- > Is this the approach we want to take to keep the default syscall list > minimal? We could for example have made renameat2 use the renameat > syscall number for new arches, but it seemed best to leave a gap for new > arches to improve consistency of numbering. I think leaving the hole is best. > This patch is a no-op for arches in tree, so there's no harm for this to > wait for the v3.16 merge window. Sounds good. I guess I'll have to put this into my asm-generic tree then, unless I can get the nios2 maintainers to pick it up. If you don't mind, can you submit the first two patches to Linus directly? Arnd