From: willy@linux.intel.com (Matthew Wilcox)
Subject: [PATCH] NVMe: Update namespace and controller identity structures as per 1.1a spec
Date: Wed, 23 Apr 2014 11:13:04 -0400 [thread overview]
Message-ID: <20140423151304.GF13050@linux.intel.com> (raw)
In-Reply-To: <1397942397-29998-1-git-send-email-dimitri.ledkov@canonical.com>
On Sat, Apr 19, 2014@10:19:57PM +0100, Dimitri John Ledkov wrote:
> Controller: add CNTLID, AVSCC, APSTA, NVSCC, ACWU, SGLS fields.
>
> Namespace: add NMIC, RESCAP, EUI64 fields. EUI64 is specifically
> interesting, since it can be used to construct an UEFI NVMe device
> path for a boot entry.
>
> As per NVM Express 1.1a spec:
> http://www.nvmexpress.org/wp-content/uploads/NVM-Express-1_1a.pdf
Thanks for the patch!
> - __u8 rsvd78[178];
> + __le16 cntlid;
> + __u8 rsvd80[176];
I don't think cntlid is a little-endian value. I think it's a cookie,
so this should be __u16.
> - __u8 rsvd30[98];
> + __u8 nmic;
> + __u8 rescap;
> + __u8 rsvd32[88];
> + __le64 eui64;
eui64 isn't treated as a 64-bit value elsewhere in the kernel, rather as
an array of bytes. So I think this one should be:
__u8 eui64[8];
That matches the IEEE's recommendations:
An EUI-64 is a string of eight octets, labeled as eui[0] through eui[7].
(see http://standards.ieee.org/develop/regauth/tut/eui64.pdf)
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <willy@linux.intel.com>
To: Dimitri John Ledkov <dimitri.ledkov@surgut.co.uk>
Cc: linux-nvme@lists.infradead.org, keith.busch@intel.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] NVMe: Update namespace and controller identity structures as per 1.1a spec
Date: Wed, 23 Apr 2014 11:13:04 -0400 [thread overview]
Message-ID: <20140423151304.GF13050@linux.intel.com> (raw)
In-Reply-To: <1397942397-29998-1-git-send-email-dimitri.ledkov@canonical.com>
On Sat, Apr 19, 2014 at 10:19:57PM +0100, Dimitri John Ledkov wrote:
> Controller: add CNTLID, AVSCC, APSTA, NVSCC, ACWU, SGLS fields.
>
> Namespace: add NMIC, RESCAP, EUI64 fields. EUI64 is specifically
> interesting, since it can be used to construct an UEFI NVMe device
> path for a boot entry.
>
> As per NVM Express 1.1a spec:
> http://www.nvmexpress.org/wp-content/uploads/NVM-Express-1_1a.pdf
Thanks for the patch!
> - __u8 rsvd78[178];
> + __le16 cntlid;
> + __u8 rsvd80[176];
I don't think cntlid is a little-endian value. I think it's a cookie,
so this should be __u16.
> - __u8 rsvd30[98];
> + __u8 nmic;
> + __u8 rescap;
> + __u8 rsvd32[88];
> + __le64 eui64;
eui64 isn't treated as a 64-bit value elsewhere in the kernel, rather as
an array of bytes. So I think this one should be:
__u8 eui64[8];
That matches the IEEE's recommendations:
An EUI-64 is a string of eight octets, labeled as eui[0] through eui[7].
(see http://standards.ieee.org/develop/regauth/tut/eui64.pdf)
next prev parent reply other threads:[~2014-04-23 15:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-19 21:19 [PATCH] NVMe: Update namespace and controller identity structures as per 1.1a spec Dimitri John Ledkov
2014-04-19 21:19 ` Dimitri John Ledkov
2014-04-23 15:13 ` Matthew Wilcox [this message]
2014-04-23 15:13 ` Matthew Wilcox
2014-05-07 19:55 ` [PATCH v2] " Dimitri John Ledkov
2014-05-07 19:55 ` Dimitri John Ledkov
-- strict thread matches above, loose matches on Subject: below --
2014-04-19 21:19 [PATCH] " Dimitri John Ledkov
2014-04-19 21:17 Dimitri John Ledkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140423151304.GF13050@linux.intel.com \
--to=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.