From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Eric Sandeen <sandeen@redhat.com>, Jan Kara <jack@suse.cz>,
xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH V2] xfs: fix Q_XQUOTARM ioctl
Date: Wed, 23 Apr 2014 08:27:08 -0700 [thread overview]
Message-ID: <20140423152708.GA3326@infradead.org> (raw)
In-Reply-To: <5356B986.2060906@sandeen.net>
On Tue, Apr 22, 2014 at 01:48:38PM -0500, Eric Sandeen wrote:
> The Q_XQUOTARM quotactl was not working properly, because
> we weren't passing around proper flags. The xfs_fs_set_xstate()
> ioctl handler used the same flags for Q_XQUOTAON/OFF as
> well as for Q_XQUOTARM, but Q_XQUOTAON/OFF look for
> XFS_UQUOTA_ACCT, XFS_UQUOTA_ENFD, XFS_GQUOTA_ACCT etc,
> i.e. quota type + state, while Q_XQUOTARM looks only for
> the type of quota, i.e. XFS_DQ_USER, XFS_DQ_GROUP etc.
>
> Unfortunately these flag spaces overlap a bit, so we
> got semi-random results for Q_XQUOTARM; i.e. the value
> for XFS_DQ_USER == XFS_UQUOTA_ACCT, etc. yeargh.
>
> Add a new quotactl op vector specifically for the QUOTARM
> operation, since it operates with a different flag space.
>
> This has been broken more or less forever, AFAICT.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Looks good for now:
Reviewed-by: Christoph Hellwig <hch@lst.de>
If you have a spare cycle or two I think splitting quotaon and quotaoff might
not be an all that bad idea either.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-04-23 15:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-21 20:33 [PATCH] xfs: fix Q_XQUOTARM ioctl Eric Sandeen
2014-04-22 6:43 ` Christoph Hellwig
2014-04-22 15:54 ` Eric Sandeen
2014-04-22 18:48 ` [PATCH V2] " Eric Sandeen
2014-04-22 21:30 ` Dave Chinner
2014-04-22 21:48 ` Jan Kara
2014-04-23 15:27 ` Christoph Hellwig [this message]
2014-04-23 15:28 ` Eric Sandeen
2014-04-23 15:39 ` Christoph Hellwig
2014-05-03 11:48 ` [PATCH] " Christoph Hellwig
2014-05-03 14:36 ` Eric Sandeen
2014-05-03 15:14 ` Christoph Hellwig
2014-05-04 0:21 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140423152708.GA3326@infradead.org \
--to=hch@infradead.org \
--cc=jack@suse.cz \
--cc=sandeen@redhat.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.