All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] smack: needs kernel headers v3.0+
Date: Thu, 24 Apr 2014 12:23:23 +0300	[thread overview]
Message-ID: <20140424092323.GA4397@tarshish> (raw)
In-Reply-To: <20140424111242.78331752@skate>

Hi Thomas,

On Thu, Apr 24, 2014 at 11:12:42AM +0200, Thomas Petazzoni wrote:
> On Thu, 24 Apr 2014 11:56:19 +0300, Baruch Siach wrote:
> > smack uses symbols that are exported to userspace only since Linux kernel
> > commit 1dbe39424a43 (xattr.h: expose string defines to userspace).
> > 
> > Fixes:
> > http://autobuild.buildroot.net/results/7fc/7fc69002fbb37962e65e0f83384ae7a4e6eac8a9/
> > 
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> > ---
> >  package/smack/Config.in | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> Applied... but I just realized there was a mistake:
> 
> > -comment "smack needs a toolchain w/ dynamic library"
> > +comment "smack needs a toolchain w/ dynamic library, headers >= 3.0"
> >  	depends on BR2_PREFER_STATIC_LIB
> > +	depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0
> 
> This means the comment will only be displayed if both conditions are
> met (i.e static lib is enabled *and* we don't have at least 3.0 kernel
> headers). But we need the comment to be displayed if static lib is
> enabled *OR* we don't have at least 3.0 kernel headers.
> 
> Could you send a followup patch to fix this?

Will send a fix shortly. Thanks for reviewing.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

      reply	other threads:[~2014-04-24  9:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-24  8:56 [Buildroot] [PATCH] smack: needs kernel headers v3.0+ Baruch Siach
2014-04-24  9:12 ` Thomas Petazzoni
2014-04-24  9:23   ` Baruch Siach [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140424092323.GA4397@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.