From: Brian Foster <bfoster@redhat.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v5 03/11] xfs: support the XFS_BTNUM_FINOBT free inode btree type
Date: Thu, 24 Apr 2014 07:28:22 -0400 [thread overview]
Message-ID: <20140424112820.GA51140@bfoster.bfoster> (raw)
In-Reply-To: <20140424052722.GZ15995@dastard>
On Thu, Apr 24, 2014 at 03:27:22PM +1000, Dave Chinner wrote:
> On Thu, Apr 10, 2014 at 12:08:28PM -0400, Brian Foster wrote:
> > Define the AGI fields for the finobt root/level and add magic
> > numbers. Update the btree code to add support for the new
> > XFS_BTNUM_FINOBT inode btree.
> >
> > The finobt root block is reserved immediately following the inobt
> > root block in the AG. Update XFS_PREALLOC_BLOCKS() to determine the
> > starting AG data block based on whether finobt support is enabled.
> >
> > Signed-off-by: Brian Foster <bfoster@redhat.com>
>
> Looks good.
>
> Reviewed-by: Dave Chinner <dchinner@redhat.com>
>
> FWIW, xfstests doesn't give us particularly good coverage of all
> the finobt operations:
>
> $ $ grep fibt /proc/fs/xfs/stat
> fibt2 43617 50359 338 336 0 0 0 0 0 0 0 0 0 0 136
>
> So perhaps we want to look at improving that over time.
>
Ok, noted. I'll have to think about some tests tailored to exercise the
finobt.
Brian
> Cheers,
>
> Dave.
> --
> Dave Chinner
> david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-04-24 11:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-10 16:08 [PATCH v5 00/11] xfs: introduce the free inode btree Brian Foster
2014-04-10 16:08 ` [PATCH v5 01/11] xfs: refactor xfs_ialloc_btree.c to support multiple inobt numbers Brian Foster
2014-04-10 16:08 ` [PATCH v5 02/11] xfs: reserve v5 superblock read-only compat. feature bit for finobt Brian Foster
2014-04-10 16:08 ` [PATCH v5 03/11] xfs: support the XFS_BTNUM_FINOBT free inode btree type Brian Foster
2014-04-24 5:27 ` Dave Chinner
2014-04-24 11:28 ` Brian Foster [this message]
2014-04-10 16:08 ` [PATCH v5 04/11] xfs: update inode allocation/free transaction reservations for finobt Brian Foster
2014-04-24 5:32 ` Dave Chinner
2014-04-24 11:29 ` Brian Foster
2014-04-10 16:08 ` [PATCH v5 05/11] xfs: insert newly allocated inode chunks into the finobt Brian Foster
2014-04-10 16:08 ` [PATCH v5 06/11] xfs: use and update the finobt on inode allocation Brian Foster
2014-04-24 5:44 ` Dave Chinner
2014-04-10 16:08 ` [PATCH v5 07/11] xfs: refactor xfs_difree() inobt bits into xfs_difree_inobt() helper Brian Foster
2014-04-10 16:08 ` [PATCH v5 08/11] xfs: update the finobt on inode free Brian Foster
2014-04-24 5:47 ` Dave Chinner
2014-04-10 16:08 ` [PATCH v5 09/11] xfs: add finobt support to growfs Brian Foster
2014-04-10 16:08 ` [PATCH v5 10/11] xfs: report finobt status in fs geometry Brian Foster
2014-04-10 16:08 ` [PATCH v5 11/11] xfs: enable the finobt feature on v5 superblocks Brian Foster
2014-04-14 9:46 ` [PATCH v5 00/11] xfs: introduce the free inode btree Dave Chinner
2014-04-24 5:51 ` Dave Chinner
2014-04-24 11:30 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140424112820.GA51140@bfoster.bfoster \
--to=bfoster@redhat.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.