Re: [PATCH 3/8] qtbase: move setting PACKAGECONFIG flags to arago.conf

[Denys Dmytriyenko <denys@ti.com>]

On Thu, Apr 24, 2014 at 12:33:21PM +0000, Maupin, Chase wrote:
> 
> >-----Original Message-----
> >From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> >bounces@arago-project.org] On Behalf Of Denys Dmytriyenko
> >Sent: Wednesday, April 23, 2014 8:51 PM
> >To: meta-arago@arago-project.org
> >Subject: [meta-arago] [PATCH 3/8] qtbase: move setting
> >PACKAGECONFIG flags to arago.conf
> >
> >From: Denys Dmytriyenko <denys@ti.com>
> >
> >Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> >---
> > meta-arago-distro/conf/distro/arago.conf               | 5 +++++
> > meta-arago-distro/recipes-qt/qt5/qtbase_5.2.0.bbappend | 4 +---
> > 2 files changed, 6 insertions(+), 3 deletions(-)
> >
> >diff --git a/meta-arago-distro/conf/distro/arago.conf b/meta-
> >arago-distro/conf/distro/arago.conf
> >index 1c8c572..7bd1de2 100644
> >--- a/meta-arago-distro/conf/distro/arago.conf
> >+++ b/meta-arago-distro/conf/distro/arago.conf
> >@@ -26,6 +26,11 @@ DISTRO_FEATURES = "alsa argp bluetooth ext2
> >irda largefile pcmcia usbgadget usbh
> > DISTRO_FEATURES += "opengl"
> > PACKAGECONFIG_pn-weston = "kms fbdev"
> >
> >+# Configure Qt5 flags (GLES is disabled for now)
> >+#PACKAGECONFIG_GL_pn-qtbase = "gles2 linuxfb"
> >+PACKAGECONFIG_GL_pn-qtbase = "linuxfb"
> >+PACKAGECONFIG_DISTRO_pn-qtbase = "icu"
> >+
> 
> Can you explain this a bit more?  What is the advantage of moving it to the 
> config vs in the recipe?

Most of PACKAGECONFIG flags are set automatically based on DISTRO_FEATURES, 
but not all of them. The remainder can still be thought as distro-specific.
The big thing is to set those up centrally w/o creating unnecessary bbappends. 
Of course, in this case we still need bbappend for qtbase for patches, but I 
just wanted to start consolidating different PACKAGEGROUPS in one place, like 
I did with Weston above...


> > # ARM9 is not supported by the Linaro toolchain so default back
> >to the Arago
> > # toolchain for ARM9 based SOCs.
> > TC_SANE_DEFAULT :=
> >"${@bb.utils.contains('SOC_FAMILY','omapl138','arago','linaro',d)}
> >"
> >diff --git a/meta-arago-distro/recipes-
> >qt/qt5/qtbase_5.2.0.bbappend b/meta-arago-distro/recipes-
> >qt/qt5/qtbase_5.2.0.bbappend
> >index d35a948..2c0a52d 100644
> >--- a/meta-arago-distro/recipes-qt/qt5/qtbase_5.2.0.bbappend
> >+++ b/meta-arago-distro/recipes-qt/qt5/qtbase_5.2.0.bbappend
> >@@ -1,10 +1,8 @@
> > FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
> >
> >-PACKAGECONFIG_GL = "icu linuxfb"
> >-
> > SRC_URI += " \
> > 	file://0001-qeglfswindow.cpp.patch \
> > 	file://0002-qeglfswindow.cpp.patch \
> > "
> >
> >-PR_append = "-arago0"
> >+PR_append = "-arago1"
> >--
> >1.9.2
> >
> >_______________________________________________
> >meta-arago mailing list
> >meta-arago@arago-project.org
> >http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago