From: Jonathan Nieder <jrnieder@gmail.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: git@vger.kernel.org, sunshine@sunshineco.com, peff@peff.net,
gitster@pobox.com
Subject: Re: [PATCH v5 2/9] test: add test_write_lines helper
Date: Thu, 24 Apr 2014 10:08:26 -0700 [thread overview]
Message-ID: <20140424170826.GH15516@google.com> (raw)
In-Reply-To: <1398331809-11309-2-git-send-email-mst@redhat.com>
Michael S. Tsirkin wrote:
> --- a/t/test-lib-functions.sh
> +++ b/t/test-lib-functions.sh
> @@ -712,6 +712,11 @@ test_ln_s_add () {
> fi
> }
>
> +# This function writes out its parameters, one per line
> +test_write_lines () {
> + printf "%s\n" "$@";
> +}
> +
Thanks for fixing this.
Nits:
* no need for the trailing semicolon
* it's probably worth documenting this in t/README as well so people
writing new test scripts know what it's about.
Thanks,
Jonathan
next prev parent reply other threads:[~2014-04-24 17:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 9:30 [PATCH v5 1/9] diff: add a config option to control orderfile Michael S. Tsirkin
2014-04-24 9:30 ` [PATCH v5 2/9] test: add test_write_lines helper Michael S. Tsirkin
2014-04-24 17:08 ` Jonathan Nieder [this message]
2014-04-24 18:31 ` Junio C Hamano
2014-04-24 9:30 ` [PATCH v5 3/9] tests: new test for orderfile options Michael S. Tsirkin
2014-04-24 17:11 ` Jonathan Nieder
2014-04-24 18:45 ` Junio C Hamano
2014-04-24 21:39 ` Michael S. Tsirkin
2014-04-24 9:31 ` [PATCH v5 4/9] patch-id: make it stable against hunk reordering Michael S. Tsirkin
2014-04-24 17:30 ` Jonathan Nieder
2014-04-24 19:12 ` Junio C Hamano
2014-04-24 21:32 ` Michael S. Tsirkin
2014-04-24 9:31 ` [PATCH v5 5/9] patch-id: document new behaviour Michael S. Tsirkin
2014-04-24 17:33 ` Jonathan Nieder
2014-04-24 21:26 ` Michael S. Tsirkin
2014-04-24 22:12 ` Junio C Hamano
2014-04-27 18:26 ` Michael S. Tsirkin
2014-04-24 9:31 ` [PATCH v5 6/9] patch-id-test: test stable and unstable behaviour Michael S. Tsirkin
2014-04-24 9:31 ` [PATCH v5 7/9] patch-id: change default to stable Michael S. Tsirkin
2014-04-24 9:31 ` [PATCH v5 8/9] t4204-patch-id.sh: default is now stable Michael S. Tsirkin
2014-04-24 9:31 ` [PATCH v5 9/9] Documentation/git-patch-id.txt: default is stable Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140424170826.GH15516@google.com \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mst@redhat.com \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.