Re: [PATCH V4] rrdtool: enable perl and python bindings

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2054 bytes --]

On Fri, Apr 25, 2014 at 09:21:44AM +0800, Chong Lu wrote:
> 
> On 04/24/2014 05:51 PM, Koen Kooi wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > Chong Lu schreef op 24-04-14 09:14:
> >> 1. default enable perl and python bindings 2. rrdtool uses perl.real,
> >> perl.real doesn't know where the PERL5LIB should be when prebuilts are
> >> used. Use the wrapper perl instead, perl sets PERL5LIB and invokes
> >> perl.real 3. While using dash as /bin/sh, subsequent commands in
> >> functions will not use the environment variables passed to the function
> >> call line unless explicitly run "export ENV_VAR". 4. delete unrecognized
> >> options: "--enable-local-libpng" and "--enable-local-zlib"
> >>
> >> Signed-off-by: Chong Lu <Chong.Lu@windriver.com> ---
> >> +DESCRIPTION_${PN}-perl = \ +"The ${PN}-perl package includes RRDtool
> >> bindings for perl." +FILES_${PN}-perl =
> >> "${libdir}/perl/vendor_perl/*/*.pm ${datadir}/${PN}/examples \ +
> >> ${libdir}/perl/vendor_perl/*/auto/RRDs/RRDs.*" +RDEPENDS_${PN}-perl =
> >> "perl perl-module-lib perl-module-getopt-long perl-module-time-hires \ +
> >> perl-module-io-file perl-module-ipc-open2 perl-module-io-socket"
> >> +RPROVIDES_${PN} += "${PN}-perl"
> > Why do you need RPROVIDES?
> >
> >
> >> + +DESCRIPTION_${PN}-python = \ +"The ${PN}-python package includes
> >> RRDtool bindings for python." +FILES_${PN}-python =
> >> "${libdir}/python${PYTHON_BASEVERSION}/site-packages/*"
> >> +RDEPENDS_${PN}-python = "python" +RPROVIDES_${PN} += "${PN}-python"
> > Why do you need RPROVIDES?
> If I put rrdtool-python into image.
> I got following errors when I built image.
>      Nothing RPROVIDES 'rrdtool-python'
> So, I added RPROVIDES.

Doesn't it make things even worse? It can happily install "rrdtool"
package as "rrdtool-python" provider which is not what one would expect
after adding rrdtool-python to image.

You need to add rrdtool-python rrdtool-perl to PACKAGES.

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]