From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1 v2] qdecoder : new package
Date: Fri, 25 Apr 2014 09:18:06 +0200 [thread overview]
Message-ID: <20140425091806.2bb5d65e@skate> (raw)
In-Reply-To: <78843C93FA8647B482C22C49E4C4DB0D@JohanW7>
Dear Sagaert Johan,
On Thu, 24 Apr 2014 22:43:14 +0200, Sagaert Johan wrote:
> What should I do with the BR2_PREFER_STATIC_LIB ?
> Is this a something I should add as depenency ?
Yes. You should add !BR2_PREFER_STATIC_LIB to the dependencies, and add
the corresponding comment (see the Buildroot manual for details).
> (I am not very familiar with libraries, I assume that qdecoder.a is a static library and the others (*.so.*) are shared)
>
> What should I add to finalize this patch ?
> I added a comment line to the QDECODER_CONF_OPT line for my next version of the patch.
You should get rid of the --prefix and --libdir options, by patching
the Makefile.in to add ${DESTDIR} in front of the installation paths in
the 'install' target. Then you can send this patch upstream :-)
Thanks a lot,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2014-04-25 7:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 8:25 [Buildroot] [PATCH 1/1 v2] qdecoder : new package Sagaert Johan
2014-04-22 12:35 ` Alexander Lukichev
2014-04-22 13:58 ` Mike Zick
2014-04-22 14:27 ` Thomas Petazzoni
2014-04-22 15:07 ` Sagaert Johan
2014-04-22 21:41 ` Thomas Petazzoni
2014-04-24 20:43 ` Sagaert Johan
2014-04-25 7:18 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140425091806.2bb5d65e@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.