From: Christoph Hellwig <hch@lst.de>
To: Maurizio Lombardi <mlombard@redhat.com>
Cc: linux-scsi@vger.kernel.org, JBottomley@Parallels.com, hch@lst.de
Subject: Re: [PATCH] scsi: replace numeric messages with string error messages when blk_execute_rq fails. Also add printing of sense info.
Date: Fri, 25 Apr 2014 15:12:19 +0200 [thread overview]
Message-ID: <20140425131219.GA20644@lst.de> (raw)
In-Reply-To: <1398167056-14582-1-git-send-email-mlombard@redhat.com>
On Tue, Apr 22, 2014 at 01:44:16PM +0200, Maurizio Lombardi wrote:
> Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
> ---
> drivers/scsi/device_handler/scsi_dh_alua.c | 18 ++++++++++++------
> 1 file changed, 12 insertions(+), 6 deletions(-)
Looks useful, but why do we have basically two copies of the same
code for different commands? Looking at them in detail they mostly look
like copies of scsi_execute/scsi_execute_req_flags and should be switched
to that.
next prev parent reply other threads:[~2014-04-25 13:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 11:44 [PATCH] scsi: replace numeric messages with string error messages when blk_execute_rq fails. Also add printing of sense info Maurizio Lombardi
2014-04-25 13:12 ` Christoph Hellwig [this message]
2014-04-25 15:40 ` Maurizio Lombardi
2014-04-29 9:30 ` Maurizio Lombardi
2014-04-29 18:00 ` Christoph Hellwig
2014-05-13 13:10 ` Maurizio Lombardi
2014-05-13 14:07 ` Christoph Hellwig
2014-05-13 14:14 ` Hannes Reinecke
2014-05-13 14:24 ` Maurizio Lombardi
2014-05-15 6:41 ` Christoph Hellwig
2014-06-04 7:51 ` Maurizio Lombardi
2014-06-04 7:53 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140425131219.GA20644@lst.de \
--to=hch@lst.de \
--cc=JBottomley@Parallels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mlombard@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.