From: Daniel Vetter <daniel@ffwll.ch>
To: arun.siluvery@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [RFC] tests/gem_bo_falloc: New igt for testing gem_fallocate() ioctl
Date: Fri, 25 Apr 2014 16:11:26 +0200 [thread overview]
Message-ID: <20140425141126.GV26374@phenom.ffwll.local> (raw)
In-Reply-To: <20140425141010.GU26374@phenom.ffwll.local>
On Fri, Apr 25, 2014 at 04:10:10PM +0200, Daniel Vetter wrote:
> On Fri, Apr 25, 2014 at 01:50:32PM +0100, arun.siluvery@linux.intel.com wrote:
> > +int main(int argc, char **argv)
> > +{
> > + igt_subtest_init(argc, argv);
> > +
> > + igt_fixture
> > + fd = drm_open_any();
> > +
> > + igt_subtest("gem_falloc arguments validation")
> > + test_gem_falloc_arguments_validation(fd);
>
> We tend to have no spaces in subtest names, please use dash '-' instead.
> space have a good chance to upset our tooling.
Also no need to repeat gem_falloc in each subtest, our tooling generates
an overall testcase name of "igt/$test_binary/$subtest_name". So adding
gem_falloc again is redundant.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-04-25 14:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-25 12:50 [RFC] tests/gem_bo_falloc: New igt for testing gem_fallocate() ioctl arun.siluvery
2014-04-25 14:10 ` Daniel Vetter
2014-04-25 14:11 ` Daniel Vetter [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-04-28 9:36 arun.siluvery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140425141126.GV26374@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=arun.siluvery@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.