From: Andi Kleen <ak@linux.intel.com>
To: Oren Twaig <oren@scalemp.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Shai Fultheim <shai@scalemp.com>
Subject: Re: [PATCH v2] X86: Hook apic vector allocation domain only when interrupt routing are set to ignore
Date: Fri, 25 Apr 2014 07:22:48 -0700 [thread overview]
Message-ID: <20140425142248.GL8874@tassilo.jf.intel.com> (raw)
In-Reply-To: <1398376326-3055-1-git-send-email-oren@scalemp.com>
> diff --git a/arch/x86/kernel/vsmp_64.c b/arch/x86/kernel/vsmp_64.c
> index f6584a9..b7f8e5b 100644
> --- a/arch/x86/kernel/vsmp_64.c
> +++ b/arch/x86/kernel/vsmp_64.c
> @@ -26,6 +26,8 @@
>
> #define TOPOLOGY_REGISTER_OFFSET 0x10
>
> +static int irc = 1;
Using a static for such state is very unusual. You need to describe what
protects it against races and why that is needed over a cleaner solution.
-Andi
next prev parent reply other threads:[~2014-04-25 14:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 21:52 [PATCH v2] X86: Hook apic vector allocation domain only when interrupt routing are set to ignore Oren Twaig
2014-04-25 8:01 ` Ingo Molnar
2014-04-25 11:08 ` Oren Twaig
2014-04-26 6:09 ` Ingo Molnar
2014-04-27 6:55 ` Oren Twaig
2014-04-27 11:50 ` Ingo Molnar
2014-04-25 14:22 ` Andi Kleen [this message]
2014-04-27 6:57 ` Oren Twaig
2014-04-27 11:54 ` Ingo Molnar
2014-04-27 18:34 ` Andi Kleen
2014-04-28 7:06 ` Oren Twaig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140425142248.GL8874@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=oren@scalemp.com \
--cc=shai@scalemp.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.