From: Bjorn Helgaas <bhelgaas@google.com>
To: Alexander Gordeev <agordeev@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Frank Haverkamp <haver@linux.vnet.ibm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH 1/2] GenWQE: Use pci_enable_msi_exact() instead of pci_enable_msi_block()
Date: Fri, 25 Apr 2014 12:19:11 -0600 [thread overview]
Message-ID: <20140425181911.GI32246@google.com> (raw)
In-Reply-To: <6e4ebc84c90c5f8e49a931e915ec373576ad416a.1397458024.git.agordeev@redhat.com>
On Mon, Apr 14, 2014 at 09:14:06AM +0200, Alexander Gordeev wrote:
> As result of deprecation of MSI-X/MSI enablement functions
> pci_enable_msix() and pci_enable_msi_block() all drivers
> using these two interfaces need to be updated to use the
> new pci_enable_msi_range() or pci_enable_msi_exact()
> and pci_enable_msix_range() or pci_enable_msix_exact()
> interfaces.
>
> Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
> Cc: Frank Haverkamp <haver@linux.vnet.ibm.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: linux-pci@vger.kernel.org
> Acked-by: Frank Haverkamp <haver@linux.vnet.ibm.com>
Greg, since you acked this rather than saying you applied it, I applied
this to my pci/msi branch. If you'd rather take it yourself, just let me
know.
Bjorn
> ---
> drivers/misc/genwqe/card_utils.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/misc/genwqe/card_utils.c b/drivers/misc/genwqe/card_utils.c
> index 6b1a6ef..294f667 100644
> --- a/drivers/misc/genwqe/card_utils.c
> +++ b/drivers/misc/genwqe/card_utils.c
> @@ -628,7 +628,7 @@ int genwqe_set_interrupt_capability(struct genwqe_dev *cd, int count)
> int rc;
> struct pci_dev *pci_dev = cd->pci_dev;
>
> - rc = pci_enable_msi_block(pci_dev, count);
> + rc = pci_enable_msi_exact(pci_dev, count);
> if (rc == 0)
> cd->flags |= GENWQE_FLAG_MSI_ENABLED;
> return rc;
> --
> 1.7.7.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-04-25 18:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 7:14 [PATCH 0/2] Phase out pci_enable_msi_block() Alexander Gordeev
2014-04-14 7:14 ` Alexander Gordeev
2014-04-14 7:14 ` [PATCH 1/2] GenWQE: Use pci_enable_msi_exact() instead of pci_enable_msi_block() Alexander Gordeev
2014-04-14 11:54 ` Greg Kroah-Hartman
2014-04-25 18:19 ` Bjorn Helgaas [this message]
2014-04-25 18:27 ` Greg Kroah-Hartman
2014-04-14 7:14 ` [PATCH 2/2] PCI/MSI: Phase out pci_enable_msi_block() Alexander Gordeev
2014-04-14 7:14 ` Alexander Gordeev
2014-04-14 12:09 ` Alexander Gordeev
2014-04-14 12:09 ` Alexander Gordeev
2014-04-14 13:28 ` Alexander Gordeev
2014-04-14 13:28 ` Alexander Gordeev
2014-04-30 21:19 ` Alexander Gordeev
2014-04-30 21:19 ` Alexander Gordeev
2014-04-30 23:49 ` Bjorn Helgaas
2014-04-30 23:49 ` Bjorn Helgaas
2014-05-01 16:07 ` Alexander Gordeev
2014-05-01 16:07 ` Alexander Gordeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140425181911.GI32246@google.com \
--to=bhelgaas@google.com \
--cc=agordeev@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=haver@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.