Re: [PATCH] staging: keucr: smilmain.c: Fix sparse warning

[Greg KH <gregkh@linuxfoundation.org>]

On Mon, Apr 21, 2014 at 08:42:47PM +0300, Tair wrote:
> From: Tair Rzayev <tair.rzayev@gmail.com>
> 
> Fix "Should be static" sparse warning:
> * Add Check_D_MediaFmt() declaration to smil.h;
> * Move Check_D_MediaFmt() implementation up in smilmain.c to keep
>   all the non-static functions at the top of the file;
> * Include "init.h" into "smil.h", remove externs from "smil.h"
>   which are no longer needed;
> * SM_Init[] and SM_Rdwr[] are renamed because otherwise SM_Init[]
>   collides with SM_Init() from "smil.h".

That's a lot of things to do all at once.

In fact, it doesn't apply to my tree anymore because someone else just
did a part of what you did, so this might not be needed anymore.  Can
you please rebase your patch on top of my staging-next branch on the
staging.git tree on git.kernel.org and resend it?

thanks,

greg k-h