All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Daeseok Youn <daeseok.youn@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	tulinizer@gmail.com, viro@zeniv.linux.org.uk, lorenz@badgers.com
Subject: Re: [PATCH] staging: silicom: Add appropriate ifdef conditions in bpctl_mod.c
Date: Fri, 25 Apr 2014 15:33:56 -0700	[thread overview]
Message-ID: <20140425223356.GA7045@kroah.com> (raw)
In-Reply-To: <5315479.ef9aFRk9hG@daeseok-laptop.cloud.net>

On Mon, Apr 07, 2014 at 12:03:41PM +0900, Daeseok Youn wrote:
> 
> The bp_proc_create() can be called if BP_PROC_SUPPORT is defined.
> 
> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
> ---
>  drivers/staging/silicom/bpctl_mod.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/staging/silicom/bpctl_mod.c b/drivers/staging/silicom/bpctl_mod.c
> index 6b9365b..5a3d758 100644
> --- a/drivers/staging/silicom/bpctl_mod.c
> +++ b/drivers/staging/silicom/bpctl_mod.c
> @@ -119,7 +119,10 @@ static void if_scan_init(void);
>  
>  static int bypass_proc_create_dev_sd(struct bpctl_dev *pbp_device_block);
>  static int bypass_proc_remove_dev_sd(struct bpctl_dev *pbp_device_block);
> +
> +#ifdef BP_PROC_SUPPORT
>  static int bp_proc_create(void);
> +#endif

No, this code should just be removed, right?


  reply	other threads:[~2014-04-25 22:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-07  3:03 [PATCH] staging: silicom: Add appropriate ifdef conditions in bpctl_mod.c Daeseok Youn
2014-04-25 22:33 ` Greg KH [this message]
2014-04-26  0:26   ` DaeSeok Youn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140425223356.GA7045@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=daeseok.youn@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lorenz@badgers.com \
    --cc=tulinizer@gmail.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.