From: Peter Zijlstra <peterz@infradead.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-rt-users <linux-rt-users@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [RFC PATCH] rtmutex: Do not prio boost when timeout is used
Date: Sat, 26 Apr 2014 13:04:37 +0200 [thread overview]
Message-ID: <20140426110437.GK26782@laptop.programming.kicks-ass.net> (raw)
In-Reply-To: <20140425162848.0e1deed8@gandalf.local.home>
On Fri, Apr 25, 2014 at 04:28:48PM -0400, Steven Rostedt wrote:
> I've been discussing an issue on IRC with deadlock checking and found
> something wrong with it. Mainly, if any of the locks have a timeout,
> then even if the chain loops, there is no real deadlock. If one of the
> locks in the chain times out, then things will move forward again.
POSIX (opengroup):
http://pubs.opengroup.org/onlinepubs/009695399/functions/pthread_mutex_timedlock.html
Explicitly states that pthread_mutex_timedlock() should participate in
the PI chain, it also states that its perfectly valid for this function
to return -EDEADLK.
Therefore, there's nothing wrong. If this behaviour breaks userspace,
its already broken for not actually expecting the right thing.
next prev parent reply other threads:[~2014-04-26 11:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-25 20:28 [RFC PATCH] rtmutex: Do not prio boost when timeout is used Steven Rostedt
2014-04-26 11:04 ` Peter Zijlstra [this message]
2014-04-26 11:17 ` Steven Rostedt
2014-04-27 18:20 ` Thomas Gleixner
2014-04-27 18:48 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140426110437.GK26782@laptop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.