From: Pete Wyckoff <pw@padd.com>
To: Dan Porter <dpreid@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: git p4: bug - branch detection broken on empty branches
Date: Sat, 26 Apr 2014 08:40:00 -0400 [thread overview]
Message-ID: <20140426124000.GA4767@padd.com> (raw)
In-Reply-To: <CADtnS+zAnnpaU59-rAwMHF7Z4SNjcYWASqpKdEq+GVs8mVSb3w@mail.gmail.com>
dpreid@gmail.com wrote on Tue, 22 Apr 2014 10:20 +0100:
> As part of my work to help get git-p4 close to bug-free before Git
> 2.0, I'm posting all bugs and patches to this mailing list. Please
> direct me elsewhere if this is incorrect.
>
> When trying to clone a particular directory from a depot, that
> contains one or more branches that contain no commits for that
> directory, branch detection is broken and results in a failed clone.
>
> fatal: ambiguous argument
> 'refs/remotes/p4/silly_project_branch/trunk': unknown revision or path
> not in the working tree.
[..]
> File "/home/dreid/bin/git-p4", line 2678, in importChanges
> blob = self.searchParent(parent, branch, tempBranch)
> File "/home/dreid/bin/git-p4", line 2600, in searchParent
> for blob in read_pipe_lines(["git", "rev-list", "--reverse",
> File "/home/dreid/bin/git-p4", line 155, in read_pipe_lines
> die('Command failed: %s' % str(c))
> File "/home/dreid/bin/git-p4", line 106, in die
> raise Exception(msg)
> Exception: Command failed: ['git', 'rev-list', '--reverse',
> '--no-merges', 'refs/remotes/p4/silly_project_branch/trunk']
>
> Original command:
> $ git-p4 clone //insane_depot/projects/Exchange/CompanyName/silly_project_branch@all
> silly-project --detect-branches -v
Yes, this is a good bug. You could do "git rev-parse -q --verify"
on parent before trying to read the rev-list.
But then what should happen? I suspect git-p4 will just create
that ref when it commits the change it is considering.
-- Pete
prev parent reply other threads:[~2014-04-26 12:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 9:20 git p4: bug - branch detection broken on empty branches Dan Porter
2014-04-26 12:40 ` Pete Wyckoff [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140426124000.GA4767@padd.com \
--to=pw@padd.com \
--cc=dpreid@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.