diff for duplicates of <20140426230056.GH18016@ZenIV.linux.org.uk> diff --git a/a/1.txt b/N1/1.txt index 68b461a..95f8b6e 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -31,7 +31,7 @@ which is nowhere near a sane mitigation in this case. Much saner one would be (*IF* the overflow is, indeed, possible and if simple s/int/long/ wouldn't be a better fix) something along the lines of mutex_lock(&item->mutex); - if (unlikely(item->refcount = INT_MAX)) { + if (unlikely(item->refcount == INT_MAX)) { ret = -EINVAL; <maybe whine and/or raise SIGKILL> goto out_err; diff --git a/a/content_digest b/N1/content_digest index 98f2e31..9419299 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\0535C128D.3070604@yahoo.fr\0" "From\0Al Viro <viro@zeniv.linux.org.uk>\0" "Subject\0Re: [PATCH] drm: make variable named \"refcount\" atomic, like most refcounts in the kernel.\0" - "Date\0Sat, 26 Apr 2014 23:00:56 +0000\0" + "Date\0Sun, 27 Apr 2014 00:00:56 +0100\0" "To\0Lionel Debroux <lionel_debroux@yahoo.fr>\0" "Cc\0Mateusz Guzik <mguzik@redhat.com>" linux-kernel@vger.kernel.org @@ -43,7 +43,7 @@ "be (*IF* the overflow is, indeed, possible and if simple s/int/long/ wouldn't\n" "be a better fix) something along the lines of\n" "\tmutex_lock(&item->mutex);\n" - "\tif (unlikely(item->refcount = INT_MAX)) {\n" + "\tif (unlikely(item->refcount == INT_MAX)) {\n" "\t\tret = -EINVAL;\n" "\t\t<maybe whine and/or raise SIGKILL>\n" "\t\tgoto out_err;\n" @@ -66,4 +66,4 @@ "that review, but then you should've asked them to give it to you - or do it\n" yourself if you don't want to bother them. -17b9ea44ec5fcbfbd914a4ec3830faa417d410f4ba9f558c5d7a08383870585f +6a72621738b30c72c8d1bdbe306135de81067facbb0c3f1612c50a28d42bea13
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.