All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Wang Sheng-Hui <shhuiw@gmail.com>
Cc: akpm@linux-foundation.org, kirill.shutemov@linux.intel.com,
	peterz@infradead.org, riel@redhat.com, mgorman@suse.de,
	hannes@cmpxchg.org, hughd@google.com, linux-mm@kvack.org
Subject: Re: [PATCH] mm: update the comment for high_memory
Date: Sun, 27 Apr 2014 13:46:00 +0200	[thread overview]
Message-ID: <20140427114600.GA21935@gmail.com> (raw)
In-Reply-To: <535C854C.1070105@gmail.com>


* Wang Sheng-Hui <shhuiw@gmail.com> wrote:

> 
> The system variable is not used for x86 only now. Remove the
> "x86" strings.
> 
> Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
> ---
>  mm/memory.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/mm/memory.c b/mm/memory.c
> index 93e332d..1615a64 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -85,14 +85,13 @@ EXPORT_SYMBOL(mem_map);
>  #endif
> 
>  /*
> - * A number of key systems in x86 including ioremap() rely on the assumption
> - * that high_memory defines the upper bound on direct map memory, then end
> - * of ZONE_NORMAL.  Under CONFIG_DISCONTIG this means that max_low_pfn and
> + * A number of key systems including ioremap() rely on the assumption that
> + * high_memory defines the upper bound on direct map memory, then end of
> + * ZONE_NORMAL.  Under CONFIG_DISCONTIG this means that max_low_pfn and
>   * highstart_pfn must be the same; there must be no gap between ZONE_NORMAL
>   * and ZONE_HIGHMEM.

ioremap() is not a 'key system', so if we are touching it then the 
comment should be fixed in other ways as well.

Thanks,

	Ingo

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2014-04-27 11:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-27  4:19 [PATCH] mm: update the comment for high_memory Wang Sheng-Hui
2014-04-27 11:46 ` Ingo Molnar [this message]
2014-04-28  5:03   ` Wang Sheng-Hui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140427114600.GA21935@gmail.com \
    --to=mingo@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=hughd@google.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=peterz@infradead.org \
    --cc=riel@redhat.com \
    --cc=shhuiw@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.