Re: [PATCH] Create: don't default to bitmap=internal when it is not supported

[NeilBrown <neilb@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 1056 bytes --]

On Tue, 15 Apr 2014 10:01:44 +0200 Artur Paszkiewicz
<artur.paszkiewicz@intel.com> wrote:

> For large arrays (component size > 100GB) if write-intent bitmap is not
> enabled, then it is set by default to "internal", even if the metadata
> format does support internal bitmaps, which causes Create to fail.
> 
> This patch adds checking if add_internal_bitmap is set in the
> superswitch before setting bitmap_file to "internal".
> 
> Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
> ---
>  Create.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Create.c b/Create.c
> index e42627c..602f79c 100644
> --- a/Create.c
> +++ b/Create.c
> @@ -509,6 +509,7 @@ int Create(struct supertype *st, char *mddev,
>  
>  	if (!s->bitmap_file &&
>  	    s->level >= 1 &&
> +	    st->ss->add_internal_bitmap &&
>  	    (s->write_behind || s->size > 100*1024*1024ULL)) {
>  		if (c->verbose > 0)
>  			pr_err("automatically enabling write-intent bitmap on large array\n");

Applied (at last:-)

Thanks,
NeilBrown

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]