All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: dm-devel@redhat.com, Edward Thornber <thornber@redhat.com>,
	"Alasdair G. Kergon" <agk@redhat.com>
Subject: Re: [PATCH 6/6] dm: introduce dm_ask_for_duplicate_bios
Date: Mon, 28 Apr 2014 11:45:36 -0400	[thread overview]
Message-ID: <20140428154536.GA28470@redhat.com> (raw)
In-Reply-To: <alpine.LRH.2.02.1404281107270.12081@file01.intranet.prod.int.rdu2.redhat.com>

On Mon, Apr 28 2014 at 11:09am -0400,
Mikulas Patocka <mpatocka@redhat.com> wrote:

> 
> 
> On Fri, 25 Apr 2014, Mike Snitzer wrote:
> > 
> > Hey Mikulas,
> > 
> > I'm not immediately seeing how increasing tio->num_bios from within a
> > target's map method, using dm_ask_for_duplicate_bios, will cause DM core
> > to send duplicates.
> > 
> > Nothing in DM core actually consumes tio->num_bios -- please advise.
> > 
> > Thanks,
> > Mike
> 
> tio->num_bios is a pointer. You don't increase tio->num_bios, you increase 
> the value it points to. It points to the local variable that is the limit 
> of the for loop.

I see, thanks for clarifying.

  reply	other threads:[~2014-04-28 15:45 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-14 22:40 [PATCH 1/6] dm: change sector_t len to unsigned Mikulas Patocka
2014-03-14 22:41 ` [PATCH 2/6] dm: introduce dm_accept_partial_bio Mikulas Patocka
2014-03-14 22:42   ` [PATCH 3/6] dm-snapshot: make the origin target allocate per-target structure Mikulas Patocka
2014-03-14 22:43     ` [PATCH 4/6] dm origin: split only write bios Mikulas Patocka
2014-03-14 22:43       ` [PATCH 5/6] dm: remove num_write_bios Mikulas Patocka
2014-03-14 22:44         ` [PATCH 6/6] dm: introduce dm_ask_for_duplicate_bios Mikulas Patocka
2014-04-25 18:50           ` Mike Snitzer
2014-04-28 15:09             ` Mikulas Patocka
2014-04-28 15:45               ` Mike Snitzer [this message]
2014-03-17 13:27   ` [PATCH 2/6] dm: introduce dm_accept_partial_bio Mike Snitzer
2014-03-17 17:08     ` Mikulas Patocka
2014-03-17 17:43       ` Mike Snitzer
2014-03-17 19:09         ` Mike Snitzer
2014-03-17 19:18           ` Mikulas Patocka
2014-03-17 19:47             ` Mike Snitzer
2014-03-17 22:45               ` Mikulas Patocka
2014-03-18  0:49                 ` Mike Snitzer
2014-03-18  1:26                   ` Mikulas Patocka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140428154536.GA28470@redhat.com \
    --to=snitzer@redhat.com \
    --cc=agk@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=mpatocka@redhat.com \
    --cc=thornber@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.