From: "Jörn Engel" <joern@logfs.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Matthieu Moy <matthieu.moy@grenoble-inp.fr>,
Jeff King <peff@peff.net>, Duy Nguyen <pclouds@gmail.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] Revert "Stop starting pager recursively"
Date: Mon, 28 Apr 2014 14:32:44 -0400 [thread overview]
Message-ID: <20140428183244.GA6358@logfs.org> (raw)
In-Reply-To: <xmqqk3a9s7fm.fsf@gitster.dls.corp.google.com>
On Mon, 28 April 2014 10:14:05 -0700, Junio C Hamano wrote:
> Matthieu Moy <matthieu.moy@grenoble-inp.fr> writes:
>
> > ----- Original Message -----
> >> On Sun, Apr 27, 2014 at 09:12:39AM +0700, Duy Nguyen wrote:
> >>
> >> > The intent of the commit was "that is a stupid thing to do, but it's
> >> > not so obvious from the first glance, do not freeze my system for my
> >> > mistake". But if it stops an actual use case, then I agree it should
> >> > be reverted.
> >>
> >> Thanks for the explanation. I think we should just go with Jörn's patch
> >> as-is, then.
> >
> > Agreed. At best, the commit message could be improved to explain the
> > situation, but the patch itself is OK.
>
> True and I agree.
>
> The patch needs sign-off, though (I am looking at $gmane/246644).
Signed-off-by: Joern Engel <joern@logfs.org>
Or do you want me to resend with sob?
Jörn
--
Tough times don't last, but tough people do.
-- Nigerian proverb
next prev parent reply other threads:[~2014-04-28 19:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-21 20:46 [PATCH] Revert "Stop starting pager recursively" Jörn Engel
2014-04-25 18:29 ` Jörn Engel
2014-04-25 18:49 ` Matthieu Moy
2014-04-25 20:10 ` Jörn Engel
2014-04-26 7:13 ` Jeff King
2014-04-26 17:27 ` Junio C Hamano
2014-04-26 17:35 ` Jeff King
2014-04-27 2:12 ` Duy Nguyen
2014-04-27 7:56 ` Jeff King
2014-04-27 15:06 ` Matthieu Moy
[not found] ` <xmqqk3a9s7fm.fsf@gitster.dls.corp.google.com>
2014-04-28 18:32 ` Jörn Engel [this message]
2014-04-28 23:04 ` Junio C Hamano
2014-04-28 23:39 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140428183244.GA6358@logfs.org \
--to=joern@logfs.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=matthieu.moy@grenoble-inp.fr \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.