All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Aring <alex.aring@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] Add initial regulator support
Date: Mon, 28 Apr 2014 20:51:21 +0200	[thread overview]
Message-ID: <20140428185119.GA11686@omega> (raw)
In-Reply-To: <20140428184702.GW5858@pengutronix.de>

Hi,

On Mon, Apr 28, 2014 at 08:47:02PM +0200, Sascha Hauer wrote:
> 
> I think both functions should return 0 without a valid gpio instead.
> Anyway, there's something wrong here.
> 

maybe checking on this at probe time, at the beginning or can this gpio
changed at runtime?

Maybe you don't need this here because probe will already failed with a
invalid gpio.

- Alex

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2014-04-28 18:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-28  8:18 [PATCH] initial regulator support Sascha Hauer
2014-04-28  8:18 ` [PATCH 1/2] Add " Sascha Hauer
2014-04-28 16:30   ` Alexander Aring
2014-04-28 16:41     ` Alexander Aring
2014-04-28 18:47     ` Sascha Hauer
2014-04-28 18:51       ` Alexander Aring [this message]
2014-04-28 20:00         ` Sascha Hauer
2014-04-28 20:08           ` Alexander Aring
2014-04-28  8:18 ` [PATCH 2/2] mci: Add " Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140428185119.GA11686@omega \
    --to=alex.aring@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.