All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Robert Baldyga <r.baldyga@samsung.com>
Cc: sameo@linux.intel.com, a.zummo@towertech.it,
	linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com,
	m.szyprowski@samsung.com, k.kozlowski@samsung.com
Subject: Re: [PATCH v2 1/2] mfd: max77693: remove unnecessary wrapper functions
Date: Tue, 29 Apr 2014 08:52:02 +0100	[thread overview]
Message-ID: <20140429075202.GA29462@lee--X1> (raw)
In-Reply-To: <1398750527-20715-2-git-send-email-r.baldyga@samsung.com>

> This patch removes wrapper functions used to access regmap, and
> make driver using regmap_*() functions instead.
> 
> Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
> ---
>  drivers/extcon/extcon-max77693.c     | 32 ++++++++++-----------
>  drivers/mfd/max77693-irq.c           | 50 +++++++++++++++++++-------------
>  drivers/mfd/max77693.c               | 56 ++----------------------------------
>  drivers/regulator/max77693.c         | 12 ++++----
>  include/linux/mfd/max77693-private.h |  8 ------
>  5 files changed, 54 insertions(+), 104 deletions(-)

Bye bye abstraction for the sake for abstraction. Works for me!

Acked-by: Lee Jones <lee.jones@linaro.org>

Chanwoo,
  I can add this to ib-mfd-extcon-3.16 with your Ack if you like.
  That should make things somewhat easier.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  parent reply	other threads:[~2014-04-29  7:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-29  5:48 [PATCH v2 0/2] mfd: max77693: improve regmap support Robert Baldyga
2014-04-29  5:48 ` [PATCH v2 1/2] mfd: max77693: remove unnecessary wrapper functions Robert Baldyga
2014-04-29  6:41   ` Krzysztof Kozlowski
2014-04-29  7:52   ` Lee Jones [this message]
2014-04-29  8:05     ` Chanwoo Choi
2014-04-29  5:48 ` [PATCH v2 2/2] mfd: max77693: handle IRQs using regmap Robert Baldyga
2014-04-29  6:42   ` Krzysztof Kozlowski
2014-04-29  7:59   ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140429075202.GA29462@lee--X1 \
    --to=lee.jones@linaro.org \
    --cc=a.zummo@towertech.it \
    --cc=k.kozlowski@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=r.baldyga@samsung.com \
    --cc=rtc-linux@googlegroups.com \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.