From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v2 0/7] Add cros_ec changes for newer boards Date: Tue, 29 Apr 2014 09:21:46 +0100 Message-ID: <20140429082146.GE29462@lee--X1> References: <1398185154-19404-1-git-send-email-dianders@chromium.org> <20140423123240.GA640@lee--X1> <5357E832.1000806@wwwdotorg.org> <20140428091914.GK6264@lee--X1> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Doug Anderson Cc: Mark Rutland , andrew@lunn.ch, Wolfram Sang , Andrew Bresticker , Russell King , Thierry Reding , "linux-i2c@vger.kernel.org" , Matt Porter , jdelvare@suse.de, linux-samsung-soc , Stephen Warren , Samuel Ortiz , linux-doc@vger.kernel.org, Bjorn Andersson , u.kleine-koenig@pengutronix.de, kevin.strasser@linux.intel.com, Dylan Reid , "devicetree@vger.kernel.org" , Pawel Moll , Stephen Warren , schwidefsky@de.ibm.com, laurent.pinchart+renesas@ideasonboard.com, "linux-tegra@vger.kernel.org" List-Id: linux-i2c@vger.kernel.org PiA+PiA+Pj4gTmVlZCB0byB3YWl0IGZvciB0aGUgQVJNLCBEVCBhbmQgSTJDIGd1eXMgdG8gcmV2 aWV3LCBhdCB3aGljaCBwb2ludAo+ID4+ID4+PiBJJ2xsIGJlIGhhcHB5IHRvIHRha2UgaW4gYW5k IHN1cHBseSBhIGJyYW5jaCBmb3IgdGhlbSB0byBwdWxsIGZyb20gaWYKPiA+PiA+Pj4gcmVxdWly ZWQuIElmIHRoZXJlIGFyZSBubyBfdHJ1ZV8gZGVwZW5kZW5jaWVzIGFuZCB0aGUgTUZEIGNoYW5n ZXMgY2FuCj4gPj4gPj4+IGJlIGFkZGVkIGluZGVwZW5kZW50bHkgd2l0aG91dCBmZWFyIG9mIGJ1 aWxkIGJyZWFrYWdlcywgbGV0IG1lIGtub3cKPiA+PiA+Pj4gYW5kIEknbGwgYXBwbHkgdGhlbSBz ZXBhcmF0ZWx5Lgo+ID4+ID4+Cj4gPj4gPj4gSSBiZWxpZXZlIHRoZXJlIGFyZW4ndCBkaXJlY3Qg ZGVwZW5kZW5jaWVzIGJldHdlZW4gdGhlIHBhdGNoZXMuIFNvLCB0aGUKPiA+PiA+PiBNRkQgcGF0 Y2hlcyBjYW4gYmUgYXBwbGllZCB0byB0aGUgTUZEIHRyZWUgYW5kIHRoZSBEVCBwYXRjaCBhcHBs aWVkIHRvCj4gPj4gPj4gdGhlIFRlZ3JhIHRyZWUuIEknbSBzaW1wbHkgd2FpdGluZyBmb3IgdGhl IE1GRCBwYXRjaGVzIHRvIGJlIGFwcGxpZWQKPiA+PiA+PiBiZWZvcmUgYXBwbHlpbmcgdGhlIERU IHBhdGNoIHNvIHRoYXQgSSBrbm93IHRoZSBEVCBiaW5kaW5nIGRlZmluaXRpb24gaXMKPiA+PiA+ PiBmdWxseSBhY2NlcHRlZCBiZWZvcmUgYXBwbHlpbmcgYSBwYXRjaCB0aGF0IHVzZXMgaXQuCj4g Pj4gPgo+ID4+ID4gQWxsIG9mIHRoZSBNRkQgcGF0Y2hlcyBhcmUgc2FmZSB0byBhcHBseSBhbmQg aW4gcHJldHR5IG11Y2ggYXJiaXRyYXJ5Cj4gPj4gPiBvcmRlci4gIFRoZSBzdHJvbmcgZGVwZW5k ZW5jaWVzIGluIHRoZSBjaGFpbiBhcmU6Cj4gPj4gPgo+ID4+ID4gKiBXZSBuZWVkIHBhdGNoICM1 IChtZmQ6IGNyb3NfZWM6IFN5bmMgdG8gdGhlIGxhdGVzdAo+ID4+ID4gY3Jvc19lY19jb21tYW5k cy5oIGZyb20gRUMgc291cmNlcykgYmVmb3JlIHRoZSBpMmMgdHVubmVsIGNhbiBjb21waWxlLgo+ ID4+ID4KPiA+PiA+ICogQXMgU3RlcGhlbiBzYXlzLCBoZSBzaG91bGRuJ3QgYXBwbHkgdGhlIGRl dmljZSB0cmVlIHVudGlsIHdlJ3JlCj4gPj4gPiBjb25maWRlbnQgdGhhdCB0aGUgYmluZGluZ3Mg YXJlIHJpZ2h0LiAgSG93ZXZlciB0aGVyZSdzIG5vIHN0cm9uZwo+ID4+ID4gZGVwZW5kZW5jeSBv dGhlcndpc2UuCj4gPj4gPgo+ID4+ID4gKiBQYXRjaGVzICMxICMyIGFuZCAjMyBhcmUgc2ltcGx5 IHJlbGlhYmlsaXR5IGZpeGVzLiAgVGhvc2UgY291bGQgbGFuZAo+ID4+ID4gYXQgYW55IHBvaW50 IGluIHRpbWUgYW5kIHdpbGwgaW1wcm92ZSBvdGhlciB1c2VycyBvZiBjcm9zX2VjX3NwaSAobGlr ZQo+ID4+ID4gdGhlIGtleWJvYXJkIG9uIHRlZ3JhMTI0LXZlbmljZTIpLgo+ID4+ID4KPiA+PiA+ ICogUGF0Y2ggIzQgY2FuIGFwcGx5IGFueSB0aW1lIHdpdGggbm8gaXNzdWVzLiAgV2l0aG91dCBp dCBsYXJnZSBpMmMKPiA+PiA+IHR1bm5lbCB0cmFuc2ZlcnMgd29uJ3Qgd29yaywgYnV0IHRoYXQn cyBub3QgYSB0ZXJyaWJsZSBwcm9ibGVtIChhbGwKPiA+PiA+IG5vcm1hbCB0cmFuc2ZlcnMgYXJl IHNtYWxsKS4KPiA+Pgo+ID4+IFBhdGNoICM1IChsYXRlc3QgZWMgY29tbWFuZHMpIGNhbiBhbHNv IGFwcGx5IGF0IGFueSB0aW1lIHdpdGggbm8KPiA+PiBpc3N1ZXMsIGJ1dCBpdCdzIG5lZWRlZCBm b3IgcGF0Y2ggIzYgKHRoZSB0dW5uZWwpIHRvIGNvbXBpbGUuCj4gPj4KPiA+PiBBbGwgdGhhdCBi ZWluZyBzYWlkLCBJJ2QgcmVxdWVzdCB0aGF0IHlvdSBtZXJnZSBwYXRjaGVzICMxLSM1IGFzIHNv b24KPiA+PiBhcyB5b3UgY2FuIGFuZCBtYWtlIHN1cmUgeW91IGNhbiBwcm92aWRlIGEgd2F5IHRo YXQgV29sZnJhbSBjYW4gcHVsbAo+ID4+IHRoZW0gKG9yIGF0IGxlYXN0IHBhdGNoICM1KSBpbnRv IGhpcyBpMmMgdHJlZSB0byBrZWVwIHRoZW0gYXBwbHlpbmcKPiA+PiB3aGVuIGhlIGlzIHJlYWR5 IHRvIGxhbmQgIzYuCj4gPgo+ID4gVmVyeSB3ZWxsLiBTbyBpZiBJIGNhbiBvYnRhaW4gV29sZnJh bSdzIEFjaywgSSBjYW4gYXBwbHkgdGhlIE1GRAo+ID4gY2hhbmdlcyBhbG9uZyB3aXRoIHBhdGNo ICM2IGFuZCBzdXBwbHkgaGltIHdpdGggYSBicmFuY2guCj4gCj4gQ2FuIHlvdSBleHBsYWluIHRo ZSByZWFzb24gdG8gd2FpdCBmb3IgV29sZnJhbSdzIEFjayBiZWZvcmUgYXBwbHlpbmcKPiAjMSAt ICM1PyAgSSB3b3VsZCB0aGluazoKPiAKPiAxLiBDcmVhdGUgYSB0b3BpYyBicmFuY2guCj4gMi4g QXBwbHkgcGF0Y2hlcyAxLTUgdG8gdGhlIHRvcGljIGJyYW5jaAo+IDMuIE1lcmdlIHRoZSB0b3Bp YyBicmFuY2ggdG8geW91ciBmb3ItbmV4dCBicmFuY2gKPiAKPiBXaGVuIFdvbGZyYW0gd2FudHMg dG8gdGFrZSBwYXRjaCAjNiwgaGUgY2FuIGVpdGhlcjoKPiBBLiBQdWxsIHlvdXIgdG9waWMgYnJh bmNoCj4gQi4gSWYgaXQncyBiZWVuIGxvbmcgZW5vdWdoLCBwYXRjaGVzIHdpbGwgYWxyZWFkeSBi ZSBpbiBUb1QgYW5kIG5vIGV4dHJhIHdvcmsuCj4gCj4gSWYgSSB1bmRlcnN0YW5kIGNvcnJlY3Rs eSwgdXNpbmcgYSB0b3BpYyBicmFuY2ggYW5kIGRvaW5nIG1lcmdlcyAvCj4gcHVsbHMgbWVhbnMg dGhhdCB5b3UgY2FuIHByb3ZpZGUgV29sZnJhbSB3aXRoIHN0YWJsZSBnaXQgaGFzaGVzIHdoZW4K PiBoZSBuZWVkcyB0aGVtIGFuZCB0aGVyZSB3aWxsIGJlIG5vIG1lcmdlIGNvbmZsaWN0cy4KCkkg ZG9uJ3QgdXNlIFRCcyBmb3IgTUZEIHlldCwgYXMgSSd2ZSBuZXZlciBzZWVuIHRoZSBuZWVkLiAg VGhlIGN1cnJlbnQKV29XIGlzIHRvIG9ubHkgY3JlYXRlIGV4dHJhIGJyYW5jaGVzIHdoZW4gSSBo YXZlIHBhdGNoe2VzLCBzZXRzfSB0bwpzaGFyZS4gIElmIEkgc3RhcnQgdXNpbmcgYSBtb3JlIFRC IGZvY3VzZWQgbWV0aG9kb2xvZ3kgaXQgd2lsbCBiZQppbnNpbnVhdGVkIHRoYXQgdGhlIGJyYW5j aGVzIGFyZSBzdGFibGUgLSBJIGxpa2UgdGhlIGZhY3QgdGhhdCB0aGlzIGlzCl9ub3RfIHRoZSBj YXNlLiAgQ3VycmVudGx5IEkgYW0gYWJsZSB0byByZWJhc2UsIHJld29yayBhbmQgcmVvcmRlciB0 aGUKcmVwbyBhcyBhbmQgd2hlbiBJIHNlZSBmaXQsIGFuZCBkbyByZWd1bGFybHkuIEV4Y2VwdCB0 aGUgSUJzIG9mIGNvdXJzZS4KCj4gUGF0Y2hlcyAjMSAtICM1IGFyZSBib25hZmlkZSBidWdmaXhl cyBpcnJlc3BlY3RpdmUgb2YgdGhlIGkyYyB0dW5uZWwuCgpJIG9ubHkgd2FudCB0byBjcmVhdGUg YW4gSUIgaWYgSSBrbm93IGl0J3MgZ29pbmcgdG8gYmUgdXNlZCwgZWxzZSBJJ2QKcHJlZmVyIHRo ZSBwYXRjaGVzIHJlbWFpbiB0cmFuc2llbnQuICBXaHkgYXJlIHlvdSBzbyBrZWVuIHRvIHJ1c2gg aW50bwpoYXZpbmcgdGhlc2UgcGF0Y2hlcyBhcHBsaWVkPyAgVGhleSBfd2lsbF8gbWFrZSBpdCBp bnRvIHYzLjE1LCB3aGV0aGVyCnRoZXkgYXJlIGFwcGxpZWQgaW1tZWRpYXRlbHkgb3IgYWZ0ZXIg YSBsZW5ndGggb2YgdGltZSAoaW4gdGhlIGNhc2UKdGhhdCBXb2xmcmFtIGRvZXMgbm90IHJlc3Bv bmQpLgoKLS0gCkxlZSBKb25lcwpMaW5hcm8gU1RNaWNyb2VsZWN0cm9uaWNzIExhbmRpbmcgVGVh bSBMZWFkCkxpbmFyby5vcmcg4pSCIE9wZW4gc291cmNlIHNvZnR3YXJlIGZvciBBUk0gU29DcwpG b2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3aXR0ZXIgfCBCbG9nCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcg bGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Tue, 29 Apr 2014 09:21:46 +0100 Subject: [PATCH v2 0/7] Add cros_ec changes for newer boards In-Reply-To: References: <1398185154-19404-1-git-send-email-dianders@chromium.org> <20140423123240.GA640@lee--X1> <5357E832.1000806@wwwdotorg.org> <20140428091914.GK6264@lee--X1> Message-ID: <20140429082146.GE29462@lee--X1> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > >> >>> Need to wait for the ARM, DT and I2C guys to review, at which point > >> >>> I'll be happy to take in and supply a branch for them to pull from if > >> >>> required. If there are no _true_ dependencies and the MFD changes can > >> >>> be added independently without fear of build breakages, let me know > >> >>> and I'll apply them separately. > >> >> > >> >> I believe there aren't direct dependencies between the patches. So, the > >> >> MFD patches can be applied to the MFD tree and the DT patch applied to > >> >> the Tegra tree. I'm simply waiting for the MFD patches to be applied > >> >> before applying the DT patch so that I know the DT binding definition is > >> >> fully accepted before applying a patch that uses it. > >> > > >> > All of the MFD patches are safe to apply and in pretty much arbitrary > >> > order. The strong dependencies in the chain are: > >> > > >> > * We need patch #5 (mfd: cros_ec: Sync to the latest > >> > cros_ec_commands.h from EC sources) before the i2c tunnel can compile. > >> > > >> > * As Stephen says, he shouldn't apply the device tree until we're > >> > confident that the bindings are right. However there's no strong > >> > dependency otherwise. > >> > > >> > * Patches #1 #2 and #3 are simply reliability fixes. Those could land > >> > at any point in time and will improve other users of cros_ec_spi (like > >> > the keyboard on tegra124-venice2). > >> > > >> > * Patch #4 can apply any time with no issues. Without it large i2c > >> > tunnel transfers won't work, but that's not a terrible problem (all > >> > normal transfers are small). > >> > >> Patch #5 (latest ec commands) can also apply at any time with no > >> issues, but it's needed for patch #6 (the tunnel) to compile. > >> > >> All that being said, I'd request that you merge patches #1-#5 as soon > >> as you can and make sure you can provide a way that Wolfram can pull > >> them (or at least patch #5) into his i2c tree to keep them applying > >> when he is ready to land #6. > > > > Very well. So if I can obtain Wolfram's Ack, I can apply the MFD > > changes along with patch #6 and supply him with a branch. > > Can you explain the reason to wait for Wolfram's Ack before applying > #1 - #5? I would think: > > 1. Create a topic branch. > 2. Apply patches 1-5 to the topic branch > 3. Merge the topic branch to your for-next branch > > When Wolfram wants to take patch #6, he can either: > A. Pull your topic branch > B. If it's been long enough, patches will already be in ToT and no extra work. > > If I understand correctly, using a topic branch and doing merges / > pulls means that you can provide Wolfram with stable git hashes when > he needs them and there will be no merge conflicts. I don't use TBs for MFD yet, as I've never seen the need. The current WoW is to only create extra branches when I have patch{es, sets} to share. If I start using a more TB focused methodology it will be insinuated that the branches are stable - I like the fact that this is _not_ the case. Currently I am able to rebase, rework and reorder the repo as and when I see fit, and do regularly. Except the IBs of course. > Patches #1 - #5 are bonafide bugfixes irrespective of the i2c tunnel. I only want to create an IB if I know it's going to be used, else I'd prefer the patches remain transient. Why are you so keen to rush into having these patches applied? They _will_ make it into v3.15, whether they are applied immediately or after a length of time (in the case that Wolfram does not respond). -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog