From: Dan Carpenter <dan.carpenter@oracle.com>
To: linux-scsi@vger.kernel.org
Cc: Vijaya Mohan Guvva <vmohan@brocade.com>,
Anil Gurumurthy <anil.gurumurthy@qlogic.com>,
Sudarsana Kalluru <sudarsana.kalluru@qlogic.com>
Subject: Re: [SCSI] bfa: Added support to obtain SFP info.
Date: Tue, 29 Apr 2014 15:51:00 +0300 [thread overview]
Message-ID: <20140429125100.GS4963@mwanda> (raw)
In-Reply-To: <20140327230737.GB7045@mwanda>
Krishna isn't around any more. Does anyone else know what's going on
in this code? It looks buggy to me.
regards,
dan carpenter
On Fri, Mar 28, 2014 at 02:07:37AM +0300, Dan Carpenter wrote:
> On Fri, Mar 28, 2014 at 02:05:14AM +0300, Dan Carpenter wrote:
> > Hello Krishna Gudipati,
> >
> > The patch 51e569aa1f0c: "[SCSI] bfa: Added support to obtain SFP
> > info." from Jun 24, 2011, leads to the following static checker
> > warning:
> >
> > drivers/scsi/bfa/bfa_ioc.c:3668 bfa_cb_sfp_state_query()
> > warn: add curly braces?
> >
> > drivers/scsi/bfa/bfa_ioc.c
> > 3659 static void
> > 3660 bfa_cb_sfp_state_query(struct bfa_sfp_s *sfp)
> > 3661 {
> > 3662 bfa_trc(sfp, sfp->portspeed);
> > 3663 if (sfp->media) {
> > 3664 bfa_sfp_media_get(sfp);
> > 3665 if (sfp->state_query_cbfn)
> > ^
> > Add a curly brace here?
> >
> > 3666 sfp->state_query_cbfn(sfp->state_query_cbarg,
> > 3667 sfp->status);
> > 3668 sfp->media = NULL;
> > 3669 }
> > 3670
> > 3671 if (sfp->portspeed) {
> > 3672 sfp->status = bfa_sfp_speed_valid(sfp, sfp->portspeed);
> > 3673 if (sfp->state_query_cbfn)
> > 3674 sfp->state_query_cbfn(sfp->state_query_cbarg,
> > 3675 sfp->status);
> > 3676 sfp->portspeed = BFA_PORT_SPEED_UNKNOWN;
>
> It looks like this if statement needs curly braces as well.
>
> regards,
> dan carpenter
>
> > 3677 }
> > 3678
> > 3679 sfp->state_query_lock = 0;
> > 3680 sfp->state_query_cbfn = NULL;
> >
> > ^
> > And another close curly brace here?
> >
> > 3681 }
> >
> > regards,
> > dan carpenter
next prev parent reply other threads:[~2014-04-29 12:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 23:05 [SCSI] bfa: Added support to obtain SFP info Dan Carpenter
2014-03-27 23:07 ` Dan Carpenter
2014-04-29 12:51 ` Dan Carpenter [this message]
2014-04-30 8:43 ` Anil Gurumurthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140429125100.GS4963@mwanda \
--to=dan.carpenter@oracle.com \
--cc=anil.gurumurthy@qlogic.com \
--cc=linux-scsi@vger.kernel.org \
--cc=sudarsana.kalluru@qlogic.com \
--cc=vmohan@brocade.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.