From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Patrick McHardy <kaber@trash.net>
Cc: Masanari Iida <standby24x7@gmail.com>,
netdev@vger.kernel.org, kadlec@blackhole.kfki.hu,
netfilter-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] netfilter: Fix format string mismatch in mangle_content_len()
Date: Tue, 29 Apr 2014 21:02:46 +0200 [thread overview]
Message-ID: <20140429190246.GA9993@localhost> (raw)
In-Reply-To: <20140429142119.GA12499@macbook.localnet>
On Tue, Apr 29, 2014 at 03:21:21PM +0100, Patrick McHardy wrote:
> On Tue, Apr 01, 2014 at 12:43:36AM +0900, Masanari Iida wrote:
> > Fix format string mismatch in mangle_connect_len()
>
> All these patches seem like pointless noise to me. In none of these
> cases can the value legitimately be negative. If anything, you should
> fix the types to be unsigned.
Let's do that instead. I'm going to remove these oneliners from the
nf-next queue, thanks Patrick.
prev parent reply other threads:[~2014-04-29 19:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-31 15:43 [PATCH 2/5] netfilter: Fix format string mismatch in mangle_content_len() Masanari Iida
2014-03-31 15:43 ` [PATCH 3/5] netfilter: Fix format string mismatch in _conntrack_tftp_init() Masanari Iida
2014-04-23 12:22 ` Pablo Neira Ayuso
2014-03-31 15:43 ` [PATCH 4/5] netfilter: Fix format string mismatch in nf_conntrack_irc_init() Masanari Iida
2014-04-23 12:23 ` Pablo Neira Ayuso
2014-03-31 15:43 ` [PATCH 5/5] netfilter: Fix format string mismatch in nf_conntrack_sip_init() Masanari Iida
2014-04-23 12:23 ` Pablo Neira Ayuso
2014-04-23 12:22 ` [PATCH 2/5] netfilter: Fix format string mismatch in mangle_content_len() Pablo Neira Ayuso
2014-04-29 14:21 ` Patrick McHardy
2014-04-29 19:02 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140429190246.GA9993@localhost \
--to=pablo@netfilter.org \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=standby24x7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.