From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Wed, 30 Apr 2014 11:49:59 +0200 (CEST) Received: from mail-gw1-out.broadcom.com ([216.31.210.62]:22644 "EHLO mail-gw1-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6843076AbaD3Jt4LYX8S (ORCPT ); Wed, 30 Apr 2014 11:49:56 +0200 X-IronPort-AV: E=Sophos;i="4.97,957,1389772800"; d="scan'208";a="27357543" Received: from irvexchcas08.broadcom.com (HELO IRVEXCHCAS08.corp.ad.broadcom.com) ([10.9.208.57]) by mail-gw1-out.broadcom.com with ESMTP; 30 Apr 2014 04:00:41 -0700 Received: from IRVEXCHSMTP2.corp.ad.broadcom.com (10.9.207.52) by IRVEXCHCAS08.corp.ad.broadcom.com (10.9.208.57) with Microsoft SMTP Server (TLS) id 14.3.174.1; Wed, 30 Apr 2014 02:49:47 -0700 Received: from mail-irva-13.broadcom.com (10.10.10.20) by IRVEXCHSMTP2.corp.ad.broadcom.com (10.9.207.52) with Microsoft SMTP Server id 14.3.174.1; Wed, 30 Apr 2014 02:49:48 -0700 Received: from jayachandranc.netlogicmicro.com (netl-snoppy.ban.broadcom.com [10.132.128.129]) by mail-irva-13.broadcom.com (Postfix) with ESMTP id E996051E7E; Wed, 30 Apr 2014 02:49:46 -0700 (PDT) Date: Wed, 30 Apr 2014 15:26:10 +0530 From: Jayachandran C. To: Sergei Shtylyov CC: , Subject: Re: [PATCH 11/17] MIPS: Netlogic: Fix XLP9XX pic entry Message-ID: <20140430095609.GA20504@jayachandranc.netlogicmicro.com> References: <535FE312.50400@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <535FE312.50400@cogentembedded.com> User-Agent: Mutt/1.5.21 (2010-09-15) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 39990 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: jchandra@broadcom.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Tue, Apr 29, 2014 at 09:36:18PM +0400, Sergei Shtylyov wrote: > Hello. > > On 04/29/2014 06:37 PM, Jayachandran C wrote: > > >Add the compatible property to the PIC entry. Also fix up the nodename > >to use the correct address. > > >Signed-off-by: Jayachandran C > >--- > > arch/mips/netlogic/dts/xlp_gvp.dts | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > >diff --git a/arch/mips/netlogic/dts/xlp_gvp.dts b/arch/mips/netlogic/dts/xlp_gvp.dts > >index 047d27f..bb4ecd1 100644 > >--- a/arch/mips/netlogic/dts/xlp_gvp.dts > >+++ b/arch/mips/netlogic/dts/xlp_gvp.dts > >@@ -26,11 +26,12 @@ > > interrupt-parent = <&pic>; > > interrupts = <17>; > > }; > >- pic: pic@4000 { > >- interrupt-controller; > >+ pic: pic@110000 { > > According to the ePAPR standard [1], the node name should be > "interrupt-controller@110000". > > >+ compatible = "netlogic,xlp-pic"; > > #address-cells = <0>; > > #interrupt-cells = <1>; > > reg = <0 0x110000 0x200>; > >+ interrupt-controller; > > }; The ePAPR document itself has a interrupt-controller definition which uses the node name "pic". And most of the linux kernel dts files use "pic" as well. Based on this, I think that even if the standard recommends using interrupt-contoller as the nodename, pic can be used as well. Thanks, JC. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-gw1-out.broadcom.com ([216.31.210.62]:22644 "EHLO mail-gw1-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6843076AbaD3Jt4LYX8S (ORCPT ); Wed, 30 Apr 2014 11:49:56 +0200 Date: Wed, 30 Apr 2014 15:26:10 +0530 From: Jayachandran C. Subject: Re: [PATCH 11/17] MIPS: Netlogic: Fix XLP9XX pic entry Message-ID: <20140430095609.GA20504@jayachandranc.netlogicmicro.com> References: <535FE312.50400@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <535FE312.50400@cogentembedded.com> Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Sergei Shtylyov Cc: linux-mips@linux-mips.org, ralf@linux-mips.org Message-ID: <20140430095610.FiOU3QCRieMI5SGIG5uVEoYemwRzTS6kwQiu59kYX8M@z> On Tue, Apr 29, 2014 at 09:36:18PM +0400, Sergei Shtylyov wrote: > Hello. > > On 04/29/2014 06:37 PM, Jayachandran C wrote: > > >Add the compatible property to the PIC entry. Also fix up the nodename > >to use the correct address. > > >Signed-off-by: Jayachandran C > >--- > > arch/mips/netlogic/dts/xlp_gvp.dts | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > >diff --git a/arch/mips/netlogic/dts/xlp_gvp.dts b/arch/mips/netlogic/dts/xlp_gvp.dts > >index 047d27f..bb4ecd1 100644 > >--- a/arch/mips/netlogic/dts/xlp_gvp.dts > >+++ b/arch/mips/netlogic/dts/xlp_gvp.dts > >@@ -26,11 +26,12 @@ > > interrupt-parent = <&pic>; > > interrupts = <17>; > > }; > >- pic: pic@4000 { > >- interrupt-controller; > >+ pic: pic@110000 { > > According to the ePAPR standard [1], the node name should be > "interrupt-controller@110000". > > >+ compatible = "netlogic,xlp-pic"; > > #address-cells = <0>; > > #interrupt-cells = <1>; > > reg = <0 0x110000 0x200>; > >+ interrupt-controller; > > }; The ePAPR document itself has a interrupt-controller definition which uses the node name "pic". And most of the linux kernel dts files use "pic" as well. Based on this, I think that even if the standard recommends using interrupt-contoller as the nodename, pic can be used as well. Thanks, JC.