All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurence Withers <lwithers@guralp.com>
To: hujianyang <hujianyang@huawei.com>
Cc: linux-mtd <linux-mtd@lists.infradead.org>,
	adrian.hunter@intel.com, Artem Bityutskiy <dedekind1@gmail.com>
Subject: Re: [PATCH v2] UBIFS: Fix assert failed in ubifs_set_page_dirty
Date: Wed, 30 Apr 2014 12:18:46 +0000	[thread overview]
Message-ID: <20140430121846.GI1821@guralp.com> (raw)
In-Reply-To: <536092CE.2090209@huawei.com>

On Wed, Apr 30, 2014 at 02:06:06PM +0800, hujianyang wrote:
> According to this situation, my v2 fix returns from page_mkwrite
> without performing unlock_page. We return VM_FAULT_LOCKED instead
> of just return 0. After doing this, the race above will not happen.

Hi,

I have been testing patch v1 on our hardware. Normally, at higher data rates,
we can hit the assert in under 8 hours. So far I have been running for 48
hours on one system without seeing the assert message.

I will now switch to running v2 and see if I can't find a few more systems to
run in parallel.

Many thanks, and bye for now,
-- 
Laurence Withers, <lwithers@guralp.com>                http://www.guralp.com/

  reply	other threads:[~2014-04-30 12:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-26  9:25 [PATCH RFC] UBIFS: Fix assert failed in ubifs_set_page_dirty hujianyang
2014-04-30  6:06 ` [PATCH v2] " hujianyang
2014-04-30 12:18   ` Laurence Withers [this message]
2014-04-30 13:48     ` Dolev Raviv
2014-05-04  6:38       ` hujianyang
2014-05-04 11:54         ` Dolev Raviv
2014-05-05  7:07     ` Artem Bityutskiy
2014-05-05 11:50       ` Laurence Withers
2014-05-05  7:02   ` Artem Bityutskiy
2014-05-05  7:16     ` Artem Bityutskiy
2014-05-05  7:30       ` hujianyang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140430121846.GI1821@guralp.com \
    --to=lwithers@guralp.com \
    --cc=adrian.hunter@intel.com \
    --cc=dedekind1@gmail.com \
    --cc=hujianyang@huawei.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.