All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] Patchwork cleanup #8: submitter notification
Date: Wed, 30 Apr 2014 20:05:28 +0200	[thread overview]
Message-ID: <20140430180528.GC3336@free.fr> (raw)
In-Reply-To: <20140430194048.1e070625@skate>

Thomas, All,

On 2014-04-30 19:40 +0200, Thomas Petazzoni spake thusly:
> On Wed, 30 Apr 2014 18:56:59 +0200, Yann E. MORIN wrote:
> 
> > > We do a "chown -R 0:0" on all files in the root filesystem, before
> > > taking into account device tables. So I don't see how an ownership on
> > > the build machine can leak into the generated root filesystem.
> > 
> > chown does not change the ownership of a symlink, only that of the
> > pointed-to entity:
> > 
> >     $ touch titi
> >     $ ln -s titi toto
> >     $ sudo chown root:root toto
> >     $ ls -l titi toto
> >     -rw-r--r-- 1 root   root   0 Apr 30 18:55 titi
> >     lrwxrwxrwx 1 ymorin ymorin 4 Apr 30 18:55 toto -> titi
> > 
> > So the symlink's ownership is not modified.
> 
> Should we do a chown -h -R 0:0 then?

Oh, Neat! I did not know about -h.

I was afraid that was a recent addition, but it's been in chown since
1996-05-19, so we can safely assume that even enterprise distros (that
get updated once in a blue moon) will all have it.

Yeah! :-)

I'll cook up a patch.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2014-04-30 18:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-29 19:48 [Buildroot] Patchwork cleanup #8: submitter notification Thomas De Schampheleire
2014-04-29 20:25 ` Danomi Manchego
2014-04-29 21:09 ` Yann E. MORIN
2014-04-29 22:52   ` Thomas Petazzoni
2014-04-30 16:56     ` Yann E. MORIN
2014-04-30 17:40       ` Thomas Petazzoni
2014-04-30 18:05         ` Yann E. MORIN [this message]
2014-04-30  5:19   ` Arnout Vandecappelle
2014-04-30 19:19 ` sergey kostanbaev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140430180528.GC3336@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.