All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ums: respect CONFIG_USB_CABLE_CHECK
Date: Thu, 1 May 2014 07:21:27 +0200	[thread overview]
Message-ID: <201405010721.28001.marex@denx.de> (raw)
In-Reply-To: <1398892235-9350-1-git-send-email-swarren@wwwdotorg.org>

On Wednesday, April 30, 2014 at 11:10:35 PM, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
> 
> Not all boards support usb_cable_connected(). CONFIG_USB_CABLE_CHECK is
> used elsewhere to indicate whether a board does support that function.
> Enhance cmd_usb_mass_storage.c to honor that config variable.
> 
> Cc: Przemyslaw Marczak <p.marczak@samsung.com>
> Cc: Lukasz Majewski <l.majewski@samsung.com>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
>  common/cmd_usb_mass_storage.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/common/cmd_usb_mass_storage.c b/common/cmd_usb_mass_storage.c
> index 5f557d5f857d..2f69a53acc67 100644
> --- a/common/cmd_usb_mass_storage.c
> +++ b/common/cmd_usb_mass_storage.c
> @@ -42,6 +42,7 @@ int do_usb_mass_storage(cmd_tbl_t *cmdtp, int flag,
> 
>  	g_dnl_register("ums");
> 
> +#ifdef CONFIG_USB_CABLE_CHECK
>  	/* Timeout unit: seconds */
>  	int cable_ready_timeout = UMS_CABLE_READY_TIMEOUT;
> 
> @@ -65,6 +66,7 @@ int do_usb_mass_storage(cmd_tbl_t *cmdtp, int flag,
>  		}
>  		puts("\r\n");
>  	}
> +#endif
> 
>  	while (1) {
>  		usb_gadget_handle_interrupts();

Please look at:
[PATCH v5 03/12] usb: dfu: fix boards wo USB cable detection

Does this work for you instead ?

Best regards,
Marek Vasut

  reply	other threads:[~2014-05-01  5:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-30 21:10 [U-Boot] [PATCH] ums: respect CONFIG_USB_CABLE_CHECK Stephen Warren
2014-05-01  5:21 ` Marek Vasut [this message]
2014-05-01 17:09   ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201405010721.28001.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.